From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: netdev@vger.kernel.org
Cc: oss-drivers@netronome.com, Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH net-next v2 1/5] nfp: make use of the DMA_ATTR_SKIP_CPU_SYNC attribute
Date: Fri, 21 Apr 2017 17:36:25 -0700 [thread overview]
Message-ID: <20170421173625.30774a5d@cakuba.lan> (raw)
In-Reply-To: <20170421192310.193875-2-jakub.kicinski@netronome.com>
On Fri, 21 Apr 2017 12:23:06 -0700, Jakub Kicinski wrote:
> DMA unmap may destroy changes CPU made to the buffer. To make XDP
> run correctly on non-x86 platforms we should use the
> DMA_ATTR_SKIP_CPU_SYNC attribute.
>
> Thanks to using the attribute we can now push the sync operation to the
> common code path from XDP handler.
>
> A little bit of variable name reshuffling is required to bring the
> code back to readable state.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
I think I need to add the sync for device after XDP DROP as well.
Please drop this series, I'll send v3, sorry.
next prev parent reply other threads:[~2017-04-22 0:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 19:23 [PATCH net-next v2 0/5] nfp: DMA flags, adjust head and fixes Jakub Kicinski
2017-04-21 19:23 ` [PATCH net-next v2 1/5] nfp: make use of the DMA_ATTR_SKIP_CPU_SYNC attribute Jakub Kicinski
2017-04-22 0:36 ` Jakub Kicinski [this message]
2017-04-21 19:23 ` [PATCH net-next v2 2/5] nfp: parse metadata prepend before XDP runs Jakub Kicinski
2017-04-21 19:23 ` [PATCH net-next v2 3/5] nfp: add NSP routine to get static information Jakub Kicinski
2017-04-21 19:23 ` [PATCH net-next v2 4/5] nfp: fix free list buffer size reporting Jakub Kicinski
2017-04-21 19:23 ` [PATCH net-next v2 5/5] nfp: remove the refresh of all ports optimization Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421173625.30774a5d@cakuba.lan \
--to=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox