* [PATCH iproute2] gre6: fix copy/paste bugs in GREv6 attribute manipulation
@ 2017-04-21 18:14 Craig Gallek
2017-04-23 16:15 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Craig Gallek @ 2017-04-21 18:14 UTC (permalink / raw)
To: stephen; +Cc: netdev
From: Craig Gallek <kraig@google.com>
Fixes: af89576d7a8c("iproute2: GRE over IPv6 tunnel support.")
Signed-off-by: Craig Gallek <kraig@google.com>
---
ip/link_gre6.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ip/link_gre6.c b/ip/link_gre6.c
index a91f635760fa..1b4fb051b37f 100644
--- a/ip/link_gre6.c
+++ b/ip/link_gre6.c
@@ -355,7 +355,7 @@ get_failed:
addattr_l(n, 1024, IFLA_GRE_TTL, &hop_limit, 1);
addattr_l(n, 1024, IFLA_GRE_ENCAP_LIMIT, &encap_limit, 1);
addattr_l(n, 1024, IFLA_GRE_FLOWINFO, &flowinfo, 4);
- addattr_l(n, 1024, IFLA_GRE_FLAGS, &flowinfo, 4);
+ addattr32(n, 1024, IFLA_GRE_FLAGS, flags);
addattr16(n, 1024, IFLA_GRE_ENCAP_TYPE, encaptype);
addattr16(n, 1024, IFLA_GRE_ENCAP_FLAGS, encapflags);
@@ -383,7 +383,7 @@ static void gre_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
flags = rta_getattr_u32(tb[IFLA_GRE_FLAGS]);
if (tb[IFLA_GRE_FLOWINFO])
- flags = rta_getattr_u32(tb[IFLA_GRE_FLOWINFO]);
+ flowinfo = rta_getattr_u32(tb[IFLA_GRE_FLOWINFO]);
if (tb[IFLA_GRE_REMOTE]) {
struct in6_addr addr;
--
2.12.2.816.g2cccc81164-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute2] gre6: fix copy/paste bugs in GREv6 attribute manipulation
2017-04-21 18:14 [PATCH iproute2] gre6: fix copy/paste bugs in GREv6 attribute manipulation Craig Gallek
@ 2017-04-23 16:15 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2017-04-23 16:15 UTC (permalink / raw)
To: Craig Gallek; +Cc: netdev
On Fri, 21 Apr 2017 14:14:25 -0400
Craig Gallek <kraigatgoog@gmail.com> wrote:
> From: Craig Gallek <kraig@google.com>
>
> Fixes: af89576d7a8c("iproute2: GRE over IPv6 tunnel support.")
> Signed-off-by: Craig Gallek <kraig@google.com>
Thanks. Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-23 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-21 18:14 [PATCH iproute2] gre6: fix copy/paste bugs in GREv6 attribute manipulation Craig Gallek
2017-04-23 16:15 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).