netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: alexei.starovoitov@gmail.com
Cc: daniel@iogearbox.net, netdev@vger.kernel.org
Subject: tools/testing/selftests/bpf/Makefile
Date: Sat, 22 Apr 2017 15:45:01 -0400 (EDT)	[thread overview]
Message-ID: <20170422.154501.1876167225428231606.davem@davemloft.net> (raw)


Alexei, that unconditional -D__x86_64__ isn't going to work.  It in
fact makes the build break on sparc because the types.h asm headers
explicitly check for things like __sparc__ && __arch64__ etc.

There are other places that want stuff like this, so let's do it
right.

In every

	arch/${ARCH}/Makefile

extract out the "-DXXX" stuff from CHECKFLAGS into a new Makefile
variable, expand that into CHECKFLAGS and use the new variable in
places like

	tools/testing/selftests/bpf/Makefile

and

	tools/testing/selftests/ipc/Makefile

Thanks.

             reply	other threads:[~2017-04-22 19:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-22 19:45 David Miller [this message]
2017-04-23 16:13 ` tools/testing/selftests/bpf/Makefile Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170422.154501.1876167225428231606.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexei.starovoitov@gmail.com \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).