* compile issue in latest iproute2
@ 2017-04-22 12:31 Jamal Hadi Salim
2017-04-22 15:00 ` Daniel Borkmann
0 siblings, 1 reply; 6+ messages in thread
From: Jamal Hadi Salim @ 2017-04-22 12:31 UTC (permalink / raw)
To: Daniel Borkmann, Stephen Hemminger; +Cc: netdev@vger.kernel.org
I dont think is a kernel uapi - but it was failing compiling
when HAVE_ELF is false.
-----
jhs@jhs-UX:~/git-trees/others/iproute-with-ck$ git diff include/bpf_util.h
diff --git a/include/bpf_util.h b/include/bpf_util.h
index 5361dab..edca339 100644
--- a/include/bpf_util.h
+++ b/include/bpf_util.h
@@ -266,7 +266,7 @@ int bpf_send_map_fds(const char *path, const char *obj);
int bpf_recv_map_fds(const char *path, int *fds, struct bpf_map_aux *aux,
unsigned int entries);
#else
-static inline int bpf_send_map_fds(const char *path, const char *obj)
+inline int bpf_send_map_fds(const char *path, const char *obj)
{
return 0;
}
-----
Let me know if you want a formal patch or feel free to take it.
cheers,
jamal
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: compile issue in latest iproute2
2017-04-22 12:31 compile issue in latest iproute2 Jamal Hadi Salim
@ 2017-04-22 15:00 ` Daniel Borkmann
2017-04-22 16:18 ` Daniel Borkmann
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Borkmann @ 2017-04-22 15:00 UTC (permalink / raw)
To: Jamal Hadi Salim, Stephen Hemminger; +Cc: netdev@vger.kernel.org
On 04/22/2017 02:31 PM, Jamal Hadi Salim wrote:
>
> I dont think is a kernel uapi - but it was failing compiling
> when HAVE_ELF is false.
> -----
> jhs@jhs-UX:~/git-trees/others/iproute-with-ck$ git diff include/bpf_util.h
> diff --git a/include/bpf_util.h b/include/bpf_util.h
> index 5361dab..edca339 100644
> --- a/include/bpf_util.h
> +++ b/include/bpf_util.h
> @@ -266,7 +266,7 @@ int bpf_send_map_fds(const char *path, const char *obj);
> int bpf_recv_map_fds(const char *path, int *fds, struct bpf_map_aux *aux,
> unsigned int entries);
> #else
> -static inline int bpf_send_map_fds(const char *path, const char *obj)
> +inline int bpf_send_map_fds(const char *path, const char *obj)
> {
> return 0;
> }
> -----
>
> Let me know if you want a formal patch or feel free to take it.
Will resolve it and send a patch later today, thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: compile issue in latest iproute2
2017-04-22 15:00 ` Daniel Borkmann
@ 2017-04-22 16:18 ` Daniel Borkmann
2017-04-22 16:43 ` Jamal Hadi Salim
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Borkmann @ 2017-04-22 16:18 UTC (permalink / raw)
To: Jamal Hadi Salim, Stephen Hemminger; +Cc: netdev@vger.kernel.org
On 04/22/2017 05:00 PM, Daniel Borkmann wrote:
> On 04/22/2017 02:31 PM, Jamal Hadi Salim wrote:
>>
>> I dont think is a kernel uapi - but it was failing compiling
>> when HAVE_ELF is false.
>> -----
>> jhs@jhs-UX:~/git-trees/others/iproute-with-ck$ git diff include/bpf_util.h
>> diff --git a/include/bpf_util.h b/include/bpf_util.h
>> index 5361dab..edca339 100644
>> --- a/include/bpf_util.h
>> +++ b/include/bpf_util.h
>> @@ -266,7 +266,7 @@ int bpf_send_map_fds(const char *path, const char *obj);
>> int bpf_recv_map_fds(const char *path, int *fds, struct bpf_map_aux *aux,
>> unsigned int entries);
>> #else
>> -static inline int bpf_send_map_fds(const char *path, const char *obj)
>> +inline int bpf_send_map_fds(const char *path, const char *obj)
>> {
>> return 0;
>> }
>> -----
>>
>> Let me know if you want a formal patch or feel free to take it.
>
> Will resolve it and send a patch later today, thanks!
Hmm, I'm on latest f443565f8df6 ("ip vrf: Add command name next to
pid") commit in master branch. Compiles fine for me with and without
ELF support. I verified that there's no HAVE_ELF defined and I'm
not seeing an error.
Without ELF support:
# ./configure
TC schedulers
ATM no
libc has setns: yes
SELinux support: yes
ELF support: no
libmnl support: yes
Berkeley DB: yes
docs: latex: yes
pdflatex: yes
sgml2latex: no
WARNING: no LaTeX files can be build from SGML files
sgml2html: no
WARNING: no HTML docs can be built from SGML
# make > /dev/null
ssfilter.y: conflicts: 35 shift/reduce
#
With ELF support:
# ./configure
TC schedulers
ATM no
libc has setns: yes
SELinux support: yes
ELF support: yes
libmnl support: yes
Berkeley DB: yes
docs: latex: yes
pdflatex: yes
sgml2latex: no
WARNING: no LaTeX files can be build from SGML files
sgml2html: no
WARNING: no HTML docs can be built from SGML
# make > /dev/null
ssfilter.y: conflicts: 35 shift/reduce
#
Anything I'm missing?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: compile issue in latest iproute2
2017-04-22 16:18 ` Daniel Borkmann
@ 2017-04-22 16:43 ` Jamal Hadi Salim
2017-04-22 16:54 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: Jamal Hadi Salim @ 2017-04-22 16:43 UTC (permalink / raw)
To: Daniel Borkmann, Stephen Hemminger; +Cc: netdev@vger.kernel.org
On 17-04-22 12:18 PM, Daniel Borkmann wrote:
[..]
>
> Anything I'm missing?
Let me get back to that machine (couple of hours) and try to see how i
created the issue.
Shouldve cutnpasted the error msg. Cant create it on this laptop.
cheers,
jamal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: compile issue in latest iproute2
2017-04-22 16:43 ` Jamal Hadi Salim
@ 2017-04-22 16:54 ` Stephen Hemminger
2017-04-22 20:06 ` Jamal Hadi Salim
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2017-04-22 16:54 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: Daniel Borkmann, netdev@vger.kernel.org
On Sat, 22 Apr 2017 12:43:50 -0400
Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> On 17-04-22 12:18 PM, Daniel Borkmann wrote:
> [..]
> >
> > Anything I'm missing?
>
>
> Let me get back to that machine (couple of hours) and try to see how i
> created the issue.
> Shouldve cutnpasted the error msg. Cant create it on this laptop.
>
> cheers,
> jamal
Current tip of iproute2 master compiles fine for me
both with and without HAVE_ELF
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: compile issue in latest iproute2
2017-04-22 16:54 ` Stephen Hemminger
@ 2017-04-22 20:06 ` Jamal Hadi Salim
0 siblings, 0 replies; 6+ messages in thread
From: Jamal Hadi Salim @ 2017-04-22 20:06 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Daniel Borkmann, netdev@vger.kernel.org
On 17-04-22 12:54 PM, Stephen Hemminger wrote:
> On Sat, 22 Apr 2017 12:43:50 -0400
> Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>
>> On 17-04-22 12:18 PM, Daniel Borkmann wrote:
>> [..]
>>>
>>> Anything I'm missing?
>>
>>
>> Let me get back to that machine (couple of hours) and try to see how i
>> created the issue.
>> Shouldve cutnpasted the error msg. Cant create it on this laptop.
>>
>> cheers,
>> jamal
>
> Current tip of iproute2 master compiles fine for me
> both with and without HAVE_ELF
Sorry - I cannot recreate it. I tried from scratch and did the patches
I was testing on and it compiled cleanly. Apologies for the alarm.
cheers,
jamal
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-22 20:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-22 12:31 compile issue in latest iproute2 Jamal Hadi Salim
2017-04-22 15:00 ` Daniel Borkmann
2017-04-22 16:18 ` Daniel Borkmann
2017-04-22 16:43 ` Jamal Hadi Salim
2017-04-22 16:54 ` Stephen Hemminger
2017-04-22 20:06 ` Jamal Hadi Salim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).