From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: netdev@vger.kernel.org
Cc: mst@redhat.com, jasowang@redhat.com,
virtualization@lists.linux-foundation.org, davem@davemloft.net,
Willem de Bruijn <willemb@google.com>
Subject: [PATCH net-next v3 4/5] virtio-net: clean tx descriptors from rx napi
Date: Mon, 24 Apr 2017 13:49:29 -0400 [thread overview]
Message-ID: <20170424174930.82623-5-willemdebruijn.kernel@gmail.com> (raw)
In-Reply-To: <20170424174930.82623-1-willemdebruijn.kernel@gmail.com>
From: Willem de Bruijn <willemb@google.com>
Amortize the cost of virtual interrupts by doing both rx and tx work
on reception of a receive interrupt if tx napi is enabled. With
VIRTIO_F_EVENT_IDX, this suppresses most explicit tx completion
interrupts for bidirectional workloads.
Signed-off-by: Willem de Bruijn <willemb@google.com>
---
drivers/net/virtio_net.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 4ec79e5d7a86..9dd978f34c1f 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1075,12 +1075,33 @@ static void free_old_xmit_skbs(struct send_queue *sq)
u64_stats_update_end(&stats->tx_syncp);
}
+static void virtnet_poll_cleantx(struct receive_queue *rq)
+{
+ struct virtnet_info *vi = rq->vq->vdev->priv;
+ unsigned int index = vq2rxq(rq->vq);
+ struct send_queue *sq = &vi->sq[index];
+ struct netdev_queue *txq = netdev_get_tx_queue(vi->dev, index);
+
+ if (!sq->napi.weight)
+ return;
+
+ if (__netif_tx_trylock(txq)) {
+ free_old_xmit_skbs(sq);
+ __netif_tx_unlock(txq);
+ }
+
+ if (sq->vq->num_free >= 2 + MAX_SKB_FRAGS)
+ netif_tx_wake_queue(txq);
+}
+
static int virtnet_poll(struct napi_struct *napi, int budget)
{
struct receive_queue *rq =
container_of(napi, struct receive_queue, napi);
unsigned int received;
+ virtnet_poll_cleantx(rq);
+
received = virtnet_receive(rq, budget);
/* Out of packets? */
--
2.12.2.816.g2cccc81164-goog
next prev parent reply other threads:[~2017-04-24 17:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 17:49 [PATCH net-next v3 0/5] virtio-net tx napi Willem de Bruijn
2017-04-24 17:49 ` [PATCH net-next v3 1/5] virtio-net: napi helper functions Willem de Bruijn
2017-04-24 17:49 ` [PATCH net-next v3 2/5] virtio-net: transmit napi Willem de Bruijn
2017-04-25 8:36 ` Jason Wang
2017-04-25 14:32 ` Willem de Bruijn
2017-04-24 17:49 ` [PATCH net-next v3 3/5] virtio-net: move free_old_xmit_skbs Willem de Bruijn
2017-04-24 17:49 ` Willem de Bruijn [this message]
2017-04-24 17:49 ` [PATCH net-next v3 5/5] virtio-net: keep tx interrupts disabled unless kick Willem de Bruijn
2021-04-13 5:06 ` Michael S. Tsirkin
2021-04-13 14:27 ` Willem de Bruijn
2021-04-13 19:34 ` Michael S. Tsirkin
2017-04-24 23:35 ` [PATCH net-next v3 0/5] virtio-net tx napi Michael S. Tsirkin
2017-04-25 13:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424174930.82623-5-willemdebruijn.kernel@gmail.com \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).