From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, vivien.didelot@savoifairelinux.com,
eric@anholt.net, jon.mason@broadcom.com,
Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH net 3/3] net: dsa: b53: Fix CPU port for 58xx devices
Date: Mon, 24 Apr 2017 14:27:23 -0700 [thread overview]
Message-ID: <20170424212723.15407-4-f.fainelli@gmail.com> (raw)
In-Reply-To: <20170424212723.15407-1-f.fainelli@gmail.com>
The 58xx devices (Northstar Plus) do actually have their CPU port wired
at port 8, it was unfortunately set to port 5 (B53_CPU_PORT_25) which is
incorrect, since that is the second possible management port.
Fixes: 991a36bb4645 ("net: dsa: b53: Add support for BCM585xx/586xx/88312 integrated switch")
Reported-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/dsa/b53/b53_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
index b66ee18cbe49..fa0eece21eef 100644
--- a/drivers/net/dsa/b53/b53_common.c
+++ b/drivers/net/dsa/b53/b53_common.c
@@ -1764,7 +1764,7 @@ static const struct b53_chip_data b53_switch_chips[] = {
.vlans = 4096,
.enabled_ports = 0x1ff,
.arl_entries = 4,
- .cpu_port = B53_CPU_PORT_25,
+ .cpu_port = B53_CPU_PORT,
.vta_regs = B53_VTA_REGS,
.duplex_reg = B53_DUPLEX_STAT_GE,
.jumbo_pm_reg = B53_JUMBO_PORT_MASK,
--
2.9.3
next prev parent reply other threads:[~2017-04-24 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 21:27 [PATCH net 0/3] net: dsa: b53: BCM58xx devices fixes Florian Fainelli
2017-04-24 21:27 ` [PATCH net 1/3] net: dsa: b53: Include IMP/CPU port in dumb forwarding mode Florian Fainelli
2017-04-24 21:27 ` [PATCH net 2/3] net: dsa: b53: Implement software reset for 58xx devices Florian Fainelli
2017-04-24 21:27 ` Florian Fainelli [this message]
2017-04-24 21:32 ` [PATCH net 0/3] net: dsa: b53: BCM58xx devices fixes Eric Anholt
2017-04-24 22:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424212723.15407-4-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=eric@anholt.net \
--cc=jon.mason@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoifairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).