* [PATCH net-next] selftests/net: Fix broken test case in psock_fanout
@ 2017-04-25 1:29 Mike Maloney
2017-04-25 15:56 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mike Maloney @ 2017-04-25 1:29 UTC (permalink / raw)
To: netdev, davem; +Cc: Mike Maloney
From: Mike Maloney <maloney@google.com>
The error return falue form sock_fanout_open is -1, not zero. One test
case was checking for 0 instead of -1.
Tested: Built and tested in clean client.
Signed-off-by: Mike Maloney <maloney@google.com>
---
tools/testing/selftests/net/psock_fanout.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/psock_fanout.c b/tools/testing/selftests/net/psock_fanout.c
index b4b1d91fcea5..989f917068d1 100644
--- a/tools/testing/selftests/net/psock_fanout.c
+++ b/tools/testing/selftests/net/psock_fanout.c
@@ -305,7 +305,7 @@ static void test_unique_fanout_group_ids(void)
exit(1);
}
- if (sock_fanout_open(PACKET_FANOUT_CPU, first_group_id)) {
+ if (sock_fanout_open(PACKET_FANOUT_CPU, first_group_id) != -1) {
fprintf(stderr, "ERROR: joined group with wrong type.\n");
exit(1);
}
--
2.13.0.rc0.306.g87b477812d-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-25 15:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-25 1:29 [PATCH net-next] selftests/net: Fix broken test case in psock_fanout Mike Maloney
2017-04-25 15:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).