netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: linux-can@vger.kernel.org, davem@davemloft.net
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
	mkl@pengutronix.de, dev@kicherer.org, netdev@vger.kernel.org
Subject: [PATCH 1/8] can: fix memory leak in initial namespace support
Date: Tue, 25 Apr 2017 08:19:38 +0200	[thread overview]
Message-ID: <20170425061945.28722-2-socketcan@hartkopp.net> (raw)
In-Reply-To: <20170425061945.28722-1-socketcan@hartkopp.net>

The can_rx_alldev_list is a per-net data structure now and allocated in
can_pernet_init(). Make sure the memory is free'd in can_pernet_exit() too.

Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
---
 net/can/af_can.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/can/af_can.c b/net/can/af_can.c
index abf7d854a94d..2c935babe466 100644
--- a/net/can/af_can.c
+++ b/net/can/af_can.c
@@ -903,6 +903,8 @@ static void can_pernet_exit(struct net *net)
 		}
 	}
 	rcu_read_unlock();
+
+	kfree(net->can.can_rx_alldev_list);
 }
 
 /*
-- 
2.11.0


  reply	other threads:[~2017-04-25  6:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25  6:19 [PATCH 0/8] Fix and complete CAN namespace support Oliver Hartkopp
2017-04-25  6:19 ` Oliver Hartkopp [this message]
2017-04-25  6:19 ` [PATCH 2/8] can: remove obsolete pernet_operations definitions Oliver Hartkopp
2017-04-25  6:19 ` [PATCH 3/8] can: remove obsolete definitions Oliver Hartkopp
2017-04-25  6:19 ` [PATCH 4/8] can: complete initial namespace support Oliver Hartkopp
2017-04-25  6:19 ` [PATCH 5/8] can: network namespace support for CAN_BCM protocol Oliver Hartkopp
2017-04-25  6:19 ` [PATCH 6/8] can: network namespace support for CAN gateway Oliver Hartkopp
2017-04-25  6:19 ` [PATCH 7/8] can: add Virtual CAN Tunnel driver (vxcan) Oliver Hartkopp
2017-04-25  6:19 ` [PATCH 8/8] can: enable module auto loading for virtual CAN interfaces Oliver Hartkopp
2017-04-25  6:48 ` [PATCH 0/8] Fix and complete CAN namespace support Marc Kleine-Budde
2017-04-25  8:43   ` Oliver Hartkopp
2017-04-25  8:45   ` Marc Kleine-Budde
2017-04-25  8:48     ` Oliver Hartkopp
2017-04-25  8:49       ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170425061945.28722-2-socketcan@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=davem@davemloft.net \
    --cc=dev@kicherer.org \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).