netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: al.kochet@gmail.com
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, sergei.shtylyov@cogentembedded.com,
	rogerq@ti.com, madalin.bucur@nxp.com
Subject: Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt
Date: Wed, 26 Apr 2017 14:36:00 -0400 (EDT)	[thread overview]
Message-ID: <20170426.143600.2106204643264382419.davem@davemloft.net> (raw)
In-Reply-To: <1492686004-30527-2-git-send-email-al.kochet@gmail.com>

From: Alexander Kochetkov <al.kochet@gmail.com>
Date: Thu, 20 Apr 2017 14:00:04 +0300

> The Ethernet link on an interrupt driven PHY was not coming up if the Ethernet
> cable was plugged before the Ethernet interface was brought up.
> 
> The patch trigger PHY state machine to update link state if PHY was requested to
> do auto-negotiation and auto-negotiation complete flag already set.
> 
> During power-up cycle the PHY do auto-negotiation, generate interrupt and set
> auto-negotiation complete flag. Interrupt is handled by PHY state machine but
> doesn't update link state because PHY is in PHY_READY state. After some time
> MAC bring up, start and request PHY to do auto-negotiation. If there are no new
> settings to advertise genphy_config_aneg() doesn't start PHY auto-negotiation.
> PHY continue to stay in auto-negotiation complete state and doesn't fire
> interrupt. At the same time PHY state machine expect that PHY started
> auto-negotiation and is waiting for interrupt from PHY and it won't get it.
> 
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
> Cc: stable <stable@vger.kernel.org> # v4.9+

Applied, and I reverted the micrel commit too.

Thanks.

      parent reply	other threads:[~2017-04-26 18:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20 11:00 [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt Alexander Kochetkov
2017-04-20 11:00 ` Alexander Kochetkov
2017-04-20 15:33   ` Alexander Kochetkov
2017-04-21 14:18   ` Roger Quadros
2017-04-21 14:42     ` Alexander Kochetkov
2017-04-25 14:36   ` David Miller
2017-04-25 15:25     ` Alexander Kochetkov
2017-04-25 20:09       ` Alexandre Belloni
2017-04-25 20:26         ` David Miller
2017-04-25 21:07           ` Florian Fainelli
2017-04-26 10:21         ` Alexandre Belloni
2017-04-26 18:36   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170426.143600.2106204643264382419.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=al.kochet@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=rogerq@ti.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).