From: Simon Horman <simon.horman@netronome.com>
To: David Miller <davem@davemloft.net>
Cc: jhs@mojatatu.com, jakub.kicinski@netronome.com,
netdev@vger.kernel.org, johannes@sipsolutions.net,
dsa@cumulusnetworks.com, daniel@iogearbox.net,
alexei.starovoitov@gmail.com, bblanco@gmail.com,
john.fastabend@gmail.com, kubakici@wp.pl,
oss-drivers@netronome.com
Subject: Re: [oss-drivers] Re: [RFC 3/4] nfp: make use of extended ack message reporting
Date: Wed, 26 Apr 2017 20:44:56 +0200 [thread overview]
Message-ID: <20170426184455.GA1728@vergenet.net> (raw)
In-Reply-To: <20170426.104416.270999555163740292.davem@davemloft.net>
On Wed, Apr 26, 2017 at 10:44:16AM -0400, David Miller wrote:
> From: Simon Horman <simon.horman@netronome.com>
> Date: Wed, 26 Apr 2017 13:13:16 +0200
>
> > On Tue, Apr 25, 2017 at 10:20:22AM -0400, David Miller wrote:
> >> From: Jamal Hadi Salim <jhs@mojatatu.com>
> >> Date: Tue, 25 Apr 2017 08:42:32 -0400
> >>
> >> > So are we going to standardize these strings?
> >>
> >> No.
> >>
> >> > i.e what if some user has written a bash script that depends on this
> >> > string and it gets changed later.
> >>
> >> They can't do that.
> >>
> >> It's free form extra information an application may or not provide
> >> to the user when the kernel emits it.
> >
> > I don't feel strongly about this and perhaps it can be revisited at some
> > point but perhaps it would be worth documenting that he strings do not
> > form part of the UAPI as my expectation would have been that they do f.e. to
> > facilitate internationalisation.
>
> These two things are entirely separate.
>
> We can maintain uptodate translations of the strings, yet document that
> they can change at any time and are thus not UAPI.
Thanks, I see that now.
next prev parent reply other threads:[~2017-04-26 18:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 8:06 [RFC 0/4] xdp: use netlink extended ACK reporting Jakub Kicinski
2017-04-25 8:06 ` [RFC 1/4] netlink: make extended ACK setting NULL-friendly Jakub Kicinski
2017-04-25 8:13 ` Johannes Berg
2017-04-25 20:53 ` Jakub Kicinski
2017-04-26 7:17 ` Johannes Berg
2017-04-25 9:12 ` Daniel Borkmann
2017-04-25 8:06 ` [RFC 2/4] xdp: propagate extended ack to XDP setup Jakub Kicinski
2017-04-25 8:06 ` [RFC 3/4] nfp: make use of extended ack message reporting Jakub Kicinski
2017-04-25 12:42 ` Jamal Hadi Salim
2017-04-25 14:20 ` David Miller
2017-04-26 11:13 ` [oss-drivers] " Simon Horman
2017-04-26 13:03 ` Jamal Hadi Salim
2017-04-26 13:31 ` Daniel Borkmann
2017-04-26 14:44 ` David Miller
2017-04-26 18:44 ` Simon Horman [this message]
2017-04-25 8:06 ` [RFC 4/4] virtio_net: " Jakub Kicinski
2017-04-25 9:05 ` [RFC 0/4] xdp: use netlink extended ACK reporting Daniel Borkmann
2017-04-25 16:54 ` Jesper Dangaard Brouer
2017-04-25 21:00 ` Jakub Kicinski
2017-04-25 14:53 ` David Ahern
2017-04-25 21:05 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426184455.GA1728@vergenet.net \
--to=simon.horman@netronome.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bblanco@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=johannes@sipsolutions.net \
--cc=john.fastabend@gmail.com \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).