From: Stephen Hemminger <stephen@networkplumber.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: alexei.starovoitov@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 net-next v2] bpf: add support for generic xdp
Date: Fri, 28 Apr 2017 15:43:06 -0700 [thread overview]
Message-ID: <20170428154306.02864aae@xeon-e3> (raw)
In-Reply-To: <e2ca217f7b95b4dd0b5fa8650e8fcf783de73967.1493386943.git.daniel@iogearbox.net>
On Fri, 28 Apr 2017 15:44:29 +0200
Daniel Borkmann <daniel@iogearbox.net> wrote:
> diff --git a/ip/iplink.c b/ip/iplink.c
> index 866ad72..96b0da3 100644
> --- a/ip/iplink.c
> +++ b/ip/iplink.c
> @@ -606,9 +606,12 @@ int iplink_parse(int argc, char **argv, struct iplink_req *req,
> if (get_integer(&mtu, *argv, 0))
> invarg("Invalid \"mtu\" value\n", *argv);
> addattr_l(&req->n, sizeof(*req), IFLA_MTU, &mtu, 4);
> - } else if (strcmp(*argv, "xdp") == 0) {
> + } else if (strcmp(*argv, "xdpgeneric") == 0 ||
> + strcmp(*argv, "xdp") == 0) {
> + bool generic = strcmp(*argv, "xdpgeneric") == 0;
> +
> NEXT_ARG();
> - if (xdp_parse(&argc, &argv, req))
> + if (xdp_parse(&argc, &argv, req, generic))
> exit(-1);
> } else if (strcmp(*argv, "netns") == 0) {
On a slightly related note, there really ought to be bash completion
scripts for ip command. There is a slightly out of date one for tc already.
next prev parent reply other threads:[~2017-04-28 22:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 13:44 [PATCH iproute2 net-next v2] bpf: add support for generic xdp Daniel Borkmann
2017-04-28 14:21 ` David Miller
2017-04-28 22:43 ` Stephen Hemminger [this message]
2017-05-01 16:29 ` Stephen Hemminger
2017-05-01 17:33 ` Daniel Borkmann
2017-05-02 9:47 ` Quentin Monnet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428154306.02864aae@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).