* [PATCH net-next] Fix inaccurate helper function description
@ 2017-04-26 23:41 Chenbo Feng
2017-04-27 11:10 ` Daniel Borkmann
2017-05-01 2:25 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Chenbo Feng @ 2017-04-26 23:41 UTC (permalink / raw)
To: netdev, mic; +Cc: Chenbo Feng
From: Chenbo Feng <fengc@google.com>
The description inside uapi/linux/bpf.h about bpf_get_socket_uid
helper function is no longer valid. It returns overflowuid rather
than 0 when failed.
Signed-off-by: Chenbo Feng <fengc@google.com>
---
include/uapi/linux/bpf.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h
index e553529..945a1f5 100644
--- a/include/uapi/linux/bpf.h
+++ b/include/uapi/linux/bpf.h
@@ -481,8 +481,7 @@ union bpf_attr {
* u32 bpf_get_socket_uid(skb)
* Get the owner uid of the socket stored inside sk_buff.
* @skb: pointer to skb
- * Return: uid of the socket owner on success or 0 if the socket pointer
- * inside sk_buff is NULL
+ * Return: uid of the socket owner on success or overflowuid if failed.
*/
#define __BPF_FUNC_MAPPER(FN) \
FN(unspec), \
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] Fix inaccurate helper function description
2017-04-26 23:41 [PATCH net-next] Fix inaccurate helper function description Chenbo Feng
@ 2017-04-27 11:10 ` Daniel Borkmann
2017-04-28 3:55 ` Alexei Starovoitov
2017-05-01 2:25 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2017-04-27 11:10 UTC (permalink / raw)
To: Chenbo Feng; +Cc: netdev, mic, Chenbo Feng
On 04/27/2017 01:41 AM, Chenbo Feng wrote:
> From: Chenbo Feng <fengc@google.com>
>
> The description inside uapi/linux/bpf.h about bpf_get_socket_uid
> helper function is no longer valid. It returns overflowuid rather
> than 0 when failed.
>
> Signed-off-by: Chenbo Feng <fengc@google.com>
"bpf: " prefix in patch subject line would have been good.
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] Fix inaccurate helper function description
2017-04-27 11:10 ` Daniel Borkmann
@ 2017-04-28 3:55 ` Alexei Starovoitov
0 siblings, 0 replies; 4+ messages in thread
From: Alexei Starovoitov @ 2017-04-28 3:55 UTC (permalink / raw)
To: Daniel Borkmann; +Cc: Chenbo Feng, netdev, mic, Chenbo Feng
On Thu, Apr 27, 2017 at 01:10:27PM +0200, Daniel Borkmann wrote:
> On 04/27/2017 01:41 AM, Chenbo Feng wrote:
> > From: Chenbo Feng <fengc@google.com>
> >
> > The description inside uapi/linux/bpf.h about bpf_get_socket_uid
> > helper function is no longer valid. It returns overflowuid rather
> > than 0 when failed.
> >
> > Signed-off-by: Chenbo Feng <fengc@google.com>
>
> "bpf: " prefix in patch subject line would have been good.
+1
last time missing 'bpf:' prefix caused me headaches during backporting,
so please always use it.
Also please use scripts/get_maintainer.pl to make sure
maintainers cc-ed on patches.
gmail delivers netdev list emails to my mailbox with 10+ hour delay
for some reason.
Acked-by: Alexei Starovoitov <ast@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] Fix inaccurate helper function description
2017-04-26 23:41 [PATCH net-next] Fix inaccurate helper function description Chenbo Feng
2017-04-27 11:10 ` Daniel Borkmann
@ 2017-05-01 2:25 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2017-05-01 2:25 UTC (permalink / raw)
To: chenbofeng.kernel; +Cc: netdev, mic, fengc
From: Chenbo Feng <chenbofeng.kernel@gmail.com>
Date: Wed, 26 Apr 2017 16:41:23 -0700
> From: Chenbo Feng <fengc@google.com>
>
> The description inside uapi/linux/bpf.h about bpf_get_socket_uid
> helper function is no longer valid. It returns overflowuid rather
> than 0 when failed.
>
> Signed-off-by: Chenbo Feng <fengc@google.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-01 2:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-26 23:41 [PATCH net-next] Fix inaccurate helper function description Chenbo Feng
2017-04-27 11:10 ` Daniel Borkmann
2017-04-28 3:55 ` Alexei Starovoitov
2017-05-01 2:25 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).