From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, johannes@sipsolutions.net,
dsa@cumulusnetworks.com, daniel@iogearbox.net,
alexei.starovoitov@gmail.com, bblanco@gmail.com,
john.fastabend@gmail.com, kubakici@wp.pl,
oss-drivers@netronome.com, brouer@redhat.com, jhs@mojatatu.com
Subject: Re: [PATCH net-next 0/4] xdp: use netlink extended ACK reporting
Date: Mon, 01 May 2017 10:36:06 -0400 (EDT) [thread overview]
Message-ID: <20170501.103606.1985325558874702325.davem@davemloft.net> (raw)
In-Reply-To: <20170501044648.13022-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Sun, 30 Apr 2017 21:46:44 -0700
> This series is an attempt to make XDP more user friendly by
> enabling exploiting the recently added netlink extended ACK
> reporting to carry messages to user space.
>
> David Ahern's iproute2 ext ack patches for ip link are sufficient
> to show the errors like this:
>
> # ip link set dev p4p1 xdp obj ipip_prepend.o sec ".text"
> Error: nfp: MTU too large w/ XDP enabled
>
> Where the message is coming directly from the driver. There could
> still be a bit of a leap for a complete novice from the message
> above to the right settings, but it's a big improvement over the
> standard "Invalid argument" message.
>
> v1/non-rfc:
> - add a separate macro in patch 1;
> - add KBUILD_MODNAME as part of the message (Daniel);
> - don't print the error to logs in patch 1.
Series applied.
prev parent reply other threads:[~2017-05-01 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 4:46 [PATCH net-next 0/4] xdp: use netlink extended ACK reporting Jakub Kicinski
2017-05-01 4:46 ` [PATCH net-next 1/4] netlink: add NULL-friendly helper for setting extended ACK message Jakub Kicinski
2017-05-01 10:45 ` Daniel Borkmann
2017-05-01 4:46 ` [PATCH net-next 2/4] xdp: propagate extended ack to XDP setup Jakub Kicinski
2017-05-01 10:46 ` Daniel Borkmann
2017-05-01 4:46 ` [PATCH net-next 3/4] nfp: make use of extended ack message reporting Jakub Kicinski
2017-05-01 10:46 ` Daniel Borkmann
2017-05-01 4:46 ` [PATCH net-next 4/4] virtio_net: " Jakub Kicinski
2017-05-01 10:50 ` Daniel Borkmann
2017-05-01 14:34 ` David Miller
2017-05-01 10:32 ` [oss-drivers] [PATCH net-next 0/4] xdp: use netlink extended ACK reporting Simon Horman
2017-05-01 14:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501.103606.1985325558874702325.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexei.starovoitov@gmail.com \
--cc=bblanco@gmail.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dsa@cumulusnetworks.com \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=johannes@sipsolutions.net \
--cc=john.fastabend@gmail.com \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).