From: David Miller <davem@davemloft.net>
To: ilant@mellanox.com
Cc: steffen.klassert@secunet.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net/esp4: Fix invalid esph pointer crash
Date: Mon, 01 May 2017 14:59:15 -0400 (EDT) [thread overview]
Message-ID: <20170501.145915.1070402354847439894.davem@davemloft.net> (raw)
In-Reply-To: <20170430133438.31962-1-ilant@mellanox.com>
From: <ilant@mellanox.com>
Date: Sun, 30 Apr 2017 16:34:38 +0300
> From: Ilan Tayari <ilant@mellanox.com>
>
> Both esp_output and esp_xmit take a pointer to the ESP header
> and place it in esp_info struct prior to calling esp_output_head.
>
> Inside esp_output_head, the call to esp_output_udp_encap
> makes sure to update the pointer if it gets invalid.
> However, if esp_output_head itself calls skb_cow_data, the
> pointer is not updated and stays invalid, causing a crash
> after esp_output_head returns.
>
> Update the pointer if it becomes invalid in esp_output_head
>
> Fixes: fca11ebde3f0 ("esp4: Reorganize esp_output")
> Signed-off-by: Ilan Tayari <ilant@mellanox.com>
Looks good, applied, thanks.
next prev parent reply other threads:[~2017-05-01 18:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-30 13:34 [PATCH net-next] net/esp4: Fix invalid esph pointer crash ilant
2017-05-01 18:59 ` David Miller [this message]
2017-05-03 7:02 ` Steffen Klassert
2017-05-03 11:45 ` Ilan Tayari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501.145915.1070402354847439894.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilant@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).