From: Jesper Dangaard Brouer <brouer@redhat.com>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, ast@fb.com, daniel@iogearbox.net,
brouer@redhat.com
Subject: Re: [PATCH net-next] samples/bpf: Add support for SKB_MODE to xdp1 and xdp_tx_iptunnel
Date: Mon, 1 May 2017 11:09:56 +0200 [thread overview]
Message-ID: <20170501110956.3e82545a@redhat.com> (raw)
In-Reply-To: <5607e461-b74f-f8b7-8d47-a5341259ddff@cumulusnetworks.com>
On Sun, 30 Apr 2017 17:46:13 -0600
David Ahern <dsa@cumulusnetworks.com> wrote:
> On 4/28/17 3:40 PM, Jesper Dangaard Brouer wrote:
> > [...]
> >> diff --git a/samples/bpf/bpf_load.c b/samples/bpf/bpf_load.c
> >> index 0d449d8032d1..d4433a47e6c3 100644
> >> --- a/samples/bpf/bpf_load.c
> >> +++ b/samples/bpf/bpf_load.c
> >> @@ -563,7 +563,7 @@ struct ksym *ksym_search(long key)
> >> return &syms[0];
> >> }
> >>
> >> -int set_link_xdp_fd(int ifindex, int fd)
> >> +int set_link_xdp_fd(int ifindex, int fd, int flags)
> > Shouldn't the flags be a unsigned int, actually a __u32 ?
> >
>
> sure. I'll send a patch
I found another bug in xdp_tx_iptunnel ... I'll send a patch for both issues.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2017-05-01 9:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 16:11 [PATCH net-next] samples/bpf: Add support for SKB_MODE to xdp1 and xdp_tx_iptunnel David Ahern
2017-04-27 16:38 ` Alexei Starovoitov
2017-04-27 16:49 ` David Miller
2017-04-28 21:40 ` Jesper Dangaard Brouer
2017-04-30 23:46 ` David Ahern
2017-05-01 9:09 ` Jesper Dangaard Brouer [this message]
2017-05-01 9:26 ` [net-next PATCH 0/2] samples/bpf: two bug fixes to XDP_FLAGS_SKB_MODE attaching Jesper Dangaard Brouer
2017-05-01 9:26 ` [net-next PATCH 1/2] samples/bpf: fix SKB_MODE flag to be a 32-bit unsigned int Jesper Dangaard Brouer
2017-05-01 9:55 ` Daniel Borkmann
2017-05-01 13:27 ` Andy Gospodarek
2017-05-01 9:26 ` [net-next PATCH 2/2] samples/bpf: fix XDP_FLAGS_SKB_MODE detach for xdp_tx_iptunnel Jesper Dangaard Brouer
2017-05-01 9:56 ` Daniel Borkmann
2017-05-01 13:28 ` Andy Gospodarek
2017-05-01 14:42 ` [net-next PATCH 0/2] samples/bpf: two bug fixes to XDP_FLAGS_SKB_MODE attaching David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501110956.3e82545a@redhat.com \
--to=brouer@redhat.com \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).