From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] selftests/bpf: get rid of -D__x86_64__ Date: Wed, 03 May 2017 12:06:34 -0400 (EDT) Message-ID: <20170503.120634.1673036085707133455.davem@davemloft.net> References: <20170503041443.3125777-1-ast@fb.com> <20170503.095251.353611409224180200.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: daniel@iogearbox.net, netdev@vger.kernel.org To: ast@fb.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:38862 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753815AbdECQGs (ORCPT ); Wed, 3 May 2017 12:06:48 -0400 In-Reply-To: <20170503.095251.353611409224180200.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: From: David Miller Date: Wed, 03 May 2017 09:52:51 -0400 (EDT) > From: Alexei Starovoitov > Date: Tue, 2 May 2017 21:14:43 -0700 > >> -D__x86_64__ workaround was used to make /usr/include/features.h >> to follow expected path through the system include headers. >> This is not portable. >> Instead define dummy stubs.h which is used by 'clang -target bpf' >> >> Fixes: 6882804c916b ("selftests/bpf: add a test for overlapping packet range checks") >> Signed-off-by: Alexei Starovoitov > > Applied, thanks for getting rid of this wart. Actually, we're now back to the orignal problem I had on sparc. The issue is that you cannot resolve the core kernel __u?? types unless __sparc__ is properly defined. In file included from /home/davem/src/GIT/net/tools/testing/selftests/bpf/test_pkt_access.c:8: In file included from ../../../include/uapi/linux/bpf.h:10: /usr/include/linux/types.h:27:9: error: unknown type name '__u16' typedef __u16 __bitwise __le16; ^ We really have to do the change I mentioned the first time I brought up this issue, which is to get this via a variable set in the per-arch top-level Makefile Thanks.