From: Stephen Hemminger <stephen@networkplumber.org>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, joe@perches.com, kubakici@wp.pl,
f.fainelli@gmail.com, davem@davemloft.net
Subject: Re: [PATCH v4 net-next 04/10] net/ncsi: Ethtool operation to get NCSI topology
Date: Wed, 3 May 2017 22:21:11 -0700 [thread overview]
Message-ID: <20170503222111.749ce90b@xeon-e3> (raw)
In-Reply-To: <1493786681-27468-5-git-send-email-gwshan@linux.vnet.ibm.com>
On Wed, 3 May 2017 14:44:35 +1000
Gavin Shan <gwshan@linux.vnet.ibm.com> wrote:
> +void ncsi_ethtool_register_dev(struct net_device *dev)
> +{
> + struct ethtool_ops *ops;
> +
> + ops = (struct ethtool_ops *)(dev->ethtool_ops);
> + if (!ops)
> + return;
> +
> + ops->get_ncsi_channels = ncsi_get_channels;
> +}
> +
Instead of casting away const which opens up potential security
issues. Have two ethtool_ops structures.
next prev parent reply other threads:[~2017-05-04 5:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 4:44 [PATCH v4 net-next 00/10] net/ncsi: Add debugging functionality Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 01/10] net/ncsi: Disable HWA mode when no channels are found Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 02/10] net/ncsi: Properly track channel monitor timer state Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 03/10] net/ncsi: Enforce failover on link monitor timeout Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 04/10] net/ncsi: Ethtool operation to get NCSI topology Gavin Shan
2017-05-04 0:49 ` Andrew Lunn
2017-05-04 1:36 ` Gavin Shan
2017-05-04 5:19 ` Stephen Hemminger
2017-05-04 6:15 ` Gavin Shan
2017-05-04 9:31 ` David Laight
2017-05-08 0:19 ` Gavin Shan
2017-05-08 12:40 ` David Laight
2017-05-04 5:21 ` Stephen Hemminger [this message]
2017-05-04 6:17 ` Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 05/10] net/ncsi: Ethtool operation to get NCSI channel info Gavin Shan
2017-05-03 20:53 ` kbuild test robot
2017-05-03 4:44 ` [PATCH v4 net-next 06/10] net/ncsi: Ethtool operation to get NCSI hw statistics Gavin Shan
2017-05-03 12:47 ` Andrew Lunn
2017-05-03 13:18 ` David Miller
2017-05-04 0:05 ` Gavin Shan
2017-05-04 0:16 ` David Miller
2017-05-04 0:38 ` Gavin Shan
2017-05-04 0:34 ` Andrew Lunn
2017-05-04 0:55 ` Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 07/10] net/ncsi: Ethtool operation to get NCSI sw statistics Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 08/10] net/ncsi: Support NCSI packet generation Gavin Shan
2017-05-03 12:52 ` Andrew Lunn
2017-05-04 6:31 ` Gavin Shan
2017-05-04 12:00 ` Andrew Lunn
2017-05-08 0:25 ` Gavin Shan
2017-05-08 0:56 ` Andrew Lunn
2017-05-08 6:27 ` Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 09/10] net/ncsi: No error report on DP response to non-existing package Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 10/10] net/ncsi: Fix length of GVI response packet Gavin Shan
2017-05-03 5:25 ` [PATCH v4 net-next 00/10] net/ncsi: Add debugging functionality David Miller
2017-05-04 0:06 ` Gavin Shan
2017-05-03 12:58 ` Andrew Lunn
2017-05-04 0:09 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170503222111.749ce90b@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=joe@perches.com \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).