netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org, torvalds@linux-foundation.org,
	netdev@vger.kernel.org, johannes.berg@intel.com
Subject: Re: [PATCH] cfg80211: make RATE_INFO_BW_20 the default
Date: Thu, 04 May 2017 11:13:33 -0400 (EDT)	[thread overview]
Message-ID: <20170504.111333.814726752020791317.davem@davemloft.net> (raw)
In-Reply-To: <20170504064230.22058-1-johannes@sipsolutions.net>

From: Johannes Berg <johannes@sipsolutions.net>
Date: Thu,  4 May 2017 08:42:30 +0200

> From: Johannes Berg <johannes.berg@intel.com>
> 
> Due to the way I did the RX bitrate conversions in mac80211 with
> spatch, going setting flags to setting the value, many drivers now
> don't set the bandwidth value for 20 MHz, since with the flags it
> wasn't necessary to (there was no 20 MHz flag, only the others.)
> 
> Rather than go through and try to fix up all the drivers, instead
> renumber the enum so that 20 MHz, which is the typical bandwidth,
> actually has the value 0, making those drivers all work again.
> 
> If VHT was hit used with a driver not reporting it, e.g. iwlmvm,
> this manifested in hitting the bandwidth warning in
> cfg80211_calculate_bitrate_vht().
> 
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Johannes, would you like me to merge this in via my tree directly?

Thanks.

  reply	other threads:[~2017-05-04 15:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04  6:42 [PATCH] cfg80211: make RATE_INFO_BW_20 the default Johannes Berg
2017-05-04 15:13 ` David Miller [this message]
2017-05-04 15:16   ` Johannes Berg
     [not found]     ` <1493911002.18881.0.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2017-05-04 15:22       ` David Miller
     [not found]         ` <20170504.112257.1601480484804301664.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-05-04 17:33           ` Linus Torvalds
2017-05-04 17:15 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170504.111333.814726752020791317.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).