From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] vxlan: Add support for modifying vxlan device attributes Date: Thu, 4 May 2017 17:07:43 -0700 Message-ID: <20170504170743.3b411f21@xeon-e3> References: <1493934394-26317-1-git-send-email-girish.moodalbail@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: To: Girish Moodalbail Return-path: Received: from mail-pf0-f176.google.com ([209.85.192.176]:33362 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbdEEAHp (ORCPT ); Thu, 4 May 2017 20:07:45 -0400 Received: by mail-pf0-f176.google.com with SMTP id q20so14734883pfg.0 for ; Thu, 04 May 2017 17:07:45 -0700 (PDT) In-Reply-To: <1493934394-26317-1-git-send-email-girish.moodalbail@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 4 May 2017 14:46:34 -0700 Girish Moodalbail wrote: > Ability to change vxlan device attributes was added to kernel through > commit 8bcdc4f3a20b ("vxlan: add changelink support"), however one > cannot do the same through ip(8) command. Changing the allowed vxlan > device attributes using 'ip link set dev type vxlan > ' currently fails with 'operation not supported' > error. This failure is due to the incorrect rtnetlink message > construction for the 'ip link set' operation. > > The vxlan_parse_opt() callback function is called for parsing options > for both 'ip link add' and 'ip link set'. For the 'add' case, we pass > down default values for those attributes that were not provided as CLI > options. However, for the 'set' case we should be only passing down the > explicitly provided attributes and not any other (default) attributes. > > Signed-off-by: Girish Moodalbail > --- All these foo_set variables are ugly. This looks almost like machine generated code. It doesn't read well.