From: Jiri Benc <jbenc@redhat.com>
To: "Chiappero, Marco" <marco.chiappero@intel.com>
Cc: Dan Williams <dcbw@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"Duyck, Alexander H" <alexander.h.duyck@intel.com>,
"Grandhi, Sainath" <sainath.grandhi@intel.com>,
Mahesh Bandewar <maheshb@google.com>
Subject: Re: [PATCH net-next 9/9] ipvlan: introduce individual MAC addresses
Date: Thu, 4 May 2017 18:43:45 +0200 [thread overview]
Message-ID: <20170504184345.3f9afb8e@griffin> (raw)
In-Reply-To: <695CDAEB5A6CE2498DE413F2A9AA82960915EF08@IRSMSX101.ger.corp.intel.com>
On Thu, 4 May 2017 09:37:00 +0000, Chiappero, Marco wrote:
> This looks conceptually wrong. Yes, ipvlan works at L3 (which is an
> implementation detail anyway), but slaves are Ethernet interfaces and
> should behave as much as possible as such regardless, with an
> individual MAC address assigned.
Isn't the proper fix then converting ipvlan interfaces to be L3 only
interfaces? I.e., ARPHRD_NONE? There's not much ipvlan can do with
arbitrary Ethernet frames anyway. Of course, a flag to switch to the
new behavior would be needed in order to preserve backwards
compatibility.
This patchset looks very wrong. For proper support of multiple MAC
addresses, we have macvlan and it's pointless to add that to ipvlan.
And doing some kind of weird MAC NAT in ipvlan just to satisfy broken
tools that can't cope with multiple interfaces with the same MAC address
is wrong, too. Those tools are already broken anyway, there's nothing
preventing anyone to set the same MAC address to multiple interfaces.
I suppose those tools don't work with bonding and bridge, either?
> So, either we fix this by forcing slaves to stay in sync with master,
Yes, that's the correct behavior. Well, at least as correct as one can
get with the ipvlan broken design of pretending that an interface is L2
when in fact, it is not.
Jiri
next prev parent reply other threads:[~2017-05-04 16:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 14:51 [PATCH net-next 0/9] support unique MAC addresses for slave devices Marco Chiappero
2017-04-27 14:51 ` [PATCH net-next 1/9] ipvlan: fix coding style for the ipvlan tree Marco Chiappero
2017-04-27 14:51 ` [PATCH net-next 2/9] ipvlan: refactor ipvlan_process_multicast for readability Marco Chiappero
2017-04-27 14:51 ` [PATCH net-next 3/9] ipvlan: replace ipvlan_rcv_frame Marco Chiappero
2017-04-27 14:51 ` [PATCH net-next 4/9] ipvlan: rework the IP lookup function Marco Chiappero
2017-04-27 14:51 ` [PATCH net-next 5/9] ipvlan: improve and uniform naming Marco Chiappero
2017-04-27 14:51 ` [PATCH net-next 6/9] ipvlan: reposition three functions Marco Chiappero
2017-04-27 14:51 ` [PATCH net-next 7/9] ipvlan: relocate ipvlan_skb_crossing_ns calls Marco Chiappero
2017-04-27 14:51 ` [PATCH net-next 8/9] ipvlan: improve compiler hints Marco Chiappero
2017-04-27 15:21 ` Duyck, Alexander H
2017-04-27 15:27 ` David Laight
2017-04-27 16:05 ` David Miller
2017-04-27 14:51 ` [PATCH net-next 9/9] ipvlan: introduce individual MAC addresses Marco Chiappero
2017-04-27 16:20 ` Dan Williams
2017-04-27 16:23 ` Dan Williams
2017-05-02 15:08 ` Chiappero, Marco
2017-05-02 16:09 ` Dan Williams
2017-05-04 9:37 ` Chiappero, Marco
2017-05-04 16:43 ` Jiri Benc [this message]
2017-05-04 22:15 ` Mahesh Bandewar (महेश बंडेवार)
2017-05-08 15:29 ` Chiappero, Marco
2017-05-08 18:13 ` Dan Williams
2017-05-09 18:41 ` Chiappero, Marco
2017-05-04 22:09 ` Mahesh Bandewar (महेश बंडेवार)
2017-04-27 20:30 ` kbuild test robot
2017-04-27 19:21 ` [PATCH net-next 0/9] support unique MAC addresses for slave devices Mahesh Bandewar (महेश बंडेवार)
2017-05-02 15:12 ` Chiappero, Marco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504184345.3f9afb8e@griffin \
--to=jbenc@redhat.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=maheshb@google.com \
--cc=marco.chiappero@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sainath.grandhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).