netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Ursula Braun <ubraun@linux.vnet.ibm.com>
Cc: "hch@lst.de" <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Bart Van Assche <Bart.VanAssche@sandisk.com>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: net/smc and the RDMA core
Date: Fri, 5 May 2017 11:10:17 -0600	[thread overview]
Message-ID: <20170505171017.GA29554@obsidianresearch.com> (raw)
In-Reply-To: <750b09b5-f898-fe7f-1e82-1f6c06cc0f58@linux.vnet.ibm.com>

On Fri, May 05, 2017 at 07:06:56PM +0200, Ursula Braun wrote:

> We do not see that just loading the smc module causes this issue.The security
> risk starts with the first connection, that actually uses smc. This is only
> possible if an AF_SMC socket connection is created while the so-called
> pnet-table is available and offers a mapping between the used Ethernet
> interface and RoCE device. Such a mapping has to be configured by a user
> (via a netlink interface) and, thus, is a conscious decision by that user.

At a mimimum this escaltes any local root exploit to a full kernel
exploit in the presense of RDMA hardware, so I do not think you should
be so dimissive of the impact.

I recommend immediately sending a kconfig patch cc'd to stable making
SMC require CONFIG_BROKEN so that nobody inadvertantly turns it on.

Jason

  reply	other threads:[~2017-05-05 17:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-01 16:33 net/smc and the RDMA core Christoph Hellwig
2017-05-01 17:29 ` Bart Van Assche
     [not found]   ` <1493659776.2665.7.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-01 17:55     ` Parav Pandit
     [not found]       ` <HE1PR0502MB30048AFD086C4B0D535BFC52D1140-692Kmc8YnlL9PhveBwpv4cDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-05-02 12:41         ` Ursula Braun
2017-05-02 15:37           ` Bart Van Assche
2017-05-02 12:34     ` Ursula Braun
     [not found]       ` <dce14470-06f4-8da3-6894-cd724eac3447-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-02 14:34         ` Doug Ledford
2017-05-01 21:04 ` Steve Wise
     [not found] ` <20170501163311.GA22209-jcswGhMUV9g@public.gmane.org>
2017-05-02 12:25   ` Ursula Braun
     [not found]     ` <d9214af6-1c6f-9f95-fc00-3e4a316b4f81-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-02 18:39       ` Bart Van Assche
     [not found]         ` <1493750358.2552.13.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-03 14:40           ` Ursula Braun
2017-05-04  8:43           ` Sagi Grimberg
     [not found]             ` <1b79048f-4495-3840-e7a6-d4fa5a8dfb57-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-05-04  8:48               ` hch-jcswGhMUV9g
2017-05-04 13:08                 ` Ursula Braun
     [not found]                   ` <efa9bd6d-1df9-952a-7f32-c2ee6bffcae5-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-04 13:15                     ` Leon Romanovsky
2017-05-04 15:31                   ` Jason Gunthorpe
     [not found]                     ` <20170504153155.GB854-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-05 17:06                       ` Ursula Braun
2017-05-05 17:10                         ` Jason Gunthorpe [this message]
2017-05-06  8:25                           ` hch
     [not found]                 ` <20170504084825.GA5399-jcswGhMUV9g@public.gmane.org>
2017-05-11 16:50                   ` Ursula Braun
     [not found]                     ` <869d9fb6-0d83-5f57-f8e4-5c1ee7477b94-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-05-11 16:56                       ` hch-jcswGhMUV9g

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170505171017.GA29554@obsidianresearch.com \
    --to=jgunthorpe@obsidianresearch.com \
    --cc=Bart.VanAssche@sandisk.com \
    --cc=davem@davemloft.net \
    --cc=hch@lst.de \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sagi@grimberg.me \
    --cc=ubraun@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).