From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: sky2: Use seq_putc() in sky2_debug_show() Date: Mon, 8 May 2017 22:50:12 -0700 Message-ID: <20170508225012.508f24c0@xeon-e3> References: <1f36d45e-3ca9-bfb8-0634-901c42390e2c@users.sourceforge.net> <8594c152-68a4-c0c7-b4c6-49c753b0c748@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Lino Sanfilippo , netdev@vger.kernel.org, Mirko Lindner , LKML , kernel-janitors@vger.kernel.org To: SF Markus Elfring Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, 8 May 2017 19:42:46 +0200 SF Markus Elfring wrote: > > Which issue do you mean? I dont see any issue you fix here. =20 >=20 > Are the run time characteristics a bit nicer for the function =E2=80=9Cse= q_putc=E2=80=9D > in comparison to the function =E2=80=9Cseq_puts=E2=80=9D for printing a s= ingle line break here? >=20 > Regards, > Markus I would put this in why bother category. seq_puts is correct and this is on= ly in diagnostic output useful to developer and disabled on most distro kernels