From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: manish.chopra@cavium.com, rahul.verma@cavium.com,
Dept-GELinuxNICDev@cavium.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netxen_nic: set rcode to the return status from the call to netxen_issue_cmd
Date: Thu, 11 May 2017 12:16:33 -0400 (EDT) [thread overview]
Message-ID: <20170511.121633.1672073434604015576.davem@davemloft.net> (raw)
In-Reply-To: <20170509161942.32383-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Tue, 9 May 2017 17:19:42 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently rcode is being initialized to NX_RCODE_SUCCESS and later it
> is checked to see if it is not NX_RCODE_SUCCESS which is never true. It
> appears that there is an unintentional missing assignment of rcode from
> the return of the call to netxen_issue_cmd() that was dropped in
> an earlier fix, so add it in.
>
> Detected by CoverityScan, CID#401900 ("Logically dead code")
>
> Fixes: 2dcd5d95ad6b2 ("netxen_nic: fix cdrp race condition")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
prev parent reply other threads:[~2017-05-11 16:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-09 16:19 [PATCH] netxen_nic: set rcode to the return status from the call to netxen_issue_cmd Colin King
2017-05-11 16:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511.121633.1672073434604015576.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dept-GELinuxNICDev@cavium.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.chopra@cavium.com \
--cc=netdev@vger.kernel.org \
--cc=rahul.verma@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).