netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ihrachys@redhat.com
Cc: ja@ssi.bg, hchunhui@mail.ustc.edu.cn, netdev@vger.kernel.org
Subject: Re: [PATCH] neighbour: update neigh timestamps iff update is effective
Date: Mon, 15 May 2017 13:10:23 -0400 (EDT)	[thread overview]
Message-ID: <20170515.131023.1878814687849300375.davem@davemloft.net> (raw)
In-Reply-To: <20170510000605.6799-1-ihrachys@redhat.com>

From: Ihar Hrachyshka <ihrachys@redhat.com>
Date: Tue,  9 May 2017 17:06:05 -0700

> Sometimes neigh_update calls won't touch neither lladdr nor state, for
> example if an update arrives in locktime interval. Then we effectively
> ignore the update request, bailing out of touching the neigh entry,
> except that we still bump its timestamps.

So, in order to understand this, one has to know that the ->updated
value is tested by the protocol specific neigh code, which in turn
will thus influence whether NEIGH_UPDATE_F_OVERRIDE gets set in the
call to neigh_update() or not.

Please update your commit message to explain that this is how the
locktime mechanism influences neigh_update()'s behavior.

Thank you.

  reply	other threads:[~2017-05-15 17:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10  0:06 [PATCH] neighbour: update neigh timestamps iff update is effective Ihar Hrachyshka
2017-05-15 17:10 ` David Miller [this message]
2017-05-15 21:40   ` Ihar Hrachyshka
2017-05-16 15:47     ` Ihar Hrachyshka
2017-05-16 15:44   ` [PATCH v2] " Ihar Hrachyshka
2017-05-17 15:42     ` David Miller
2017-05-15 20:05 ` [PATCH] " Julian Anastasov
2017-05-15 21:35   ` Ihar Hrachyshka
2017-05-15 22:27     ` Julian Anastasov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170515.131023.1878814687849300375.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=hchunhui@mail.ustc.edu.cn \
    --cc=ihrachys@redhat.com \
    --cc=ja@ssi.bg \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).