From: David Miller <davem@davemloft.net>
To: ihrachys@redhat.com
Cc: jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
netdev@vger.kernel.org
Subject: Re: [PATCH] arp: honour gratuitous ARP _replies_
Date: Mon, 15 May 2017 14:08:32 -0400 (EDT) [thread overview]
Message-ID: <20170515.140832.354922796595622860.davem@davemloft.net> (raw)
In-Reply-To: <20170510001607.9716-1-ihrachys@redhat.com>
From: Ihar Hrachyshka <ihrachys@redhat.com>
Date: Tue, 9 May 2017 17:16:07 -0700
> @@ -842,8 +844,20 @@ static int arp_process(struct net *net, struct sock *sk, struct sk_buff *skb)
> It is possible, that this option should be enabled for some
> devices (strip is candidate)
> */
> - is_garp = arp->ar_op == htons(ARPOP_REQUEST) && tip == sip &&
> - addr_type == RTN_UNICAST;
> + is_garp = tip == sip && addr_type == RTN_UNICAST;
> +
> + /* Unsolicited ARP _replies_ also require target hwaddr to be
> + * the same as source.
> + */
> + if (is_garp && arp->ar_op == htons(ARPOP_REPLY))
> + is_garp =
> +#if IS_ENABLED(CONFIG_FIREWIRE_NET)
> + /* IPv4 over IEEE 1394 doesn't provide target
> + * hardware address field in its ARP payload.
> + */
> + tha &&
> +#endif
> + !memcmp(tha, sha, dev->addr_len);
>
The ifdefs here make the test harder to understand.
I would suggest removing the ifdef and letting the compiler remove the 'tha'
check if it can.
Thank you.
next prev parent reply other threads:[~2017-05-15 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 0:16 [PATCH] arp: honour gratuitous ARP _replies_ Ihar Hrachyshka
2017-05-15 18:08 ` David Miller [this message]
2017-05-15 21:16 ` Ihar Hrachyshka
2017-05-16 15:01 ` Ihar Hrachyshka
2017-05-16 14:53 ` [PATCH v2] " Ihar Hrachyshka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515.140832.354922796595622860.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ihrachys@redhat.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).