From: David Miller <davem@davemloft.net>
To: jon.mason@broadcom.com
Cc: f.fainelli@gmail.com, julia.lawall@lip6.fr,
netdev@vger.kernel.org, andrew@lunn.ch, kbuild-all@01.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings
Date: Mon, 15 May 2017 14:29:24 -0400 (EDT) [thread overview]
Message-ID: <20170515.142924.50104848465845824.davem@davemloft.net> (raw)
In-Reply-To: <CAC3K-4qtjNOfseuENeg2Q7-xKVCK-Ytz2wPQMcX_LiwPLuTAiw@mail.gmail.com>
From: Jon Mason <jon.mason@broadcom.com>
Date: Mon, 15 May 2017 13:37:09 -0400
> I would prefer #1, as I would not want to break something that was
> currently working. However, I think we should add much error logging
> here to let people know their DT is hosed (instead of silently
> working). So, this would mean applying Julia's patch, and I'll do a
> follow-on to change the breaks to continues and add the error logging
> (assuming others agree with me).
Ok, I've applied Julia's patch.
I agree that we shouldn't fail the whole list just because one does.
And yes, we should emit enough diagnostics so that people can figure
out what the problem is.
prev parent reply other threads:[~2017-05-15 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 14:54 [PATCH] mdio: mux: fix device_node_continue.cocci warnings Julia Lawall
2017-05-12 16:22 ` David Miller
2017-05-12 22:52 ` Florian Fainelli
2017-05-13 0:40 ` Julia Lawall
2017-05-15 17:37 ` Jon Mason
2017-05-15 18:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515.142924.50104848465845824.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=jon.mason@broadcom.com \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).