netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] net: netcp: fix check of requested timestamping filter
@ 2017-05-15 14:04 Miroslav Lichvar
  2017-05-15 15:03 ` Richard Cochran
  2017-05-15 19:21 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Miroslav Lichvar @ 2017-05-15 14:04 UTC (permalink / raw)
  To: netdev; +Cc: WingMan Kwok, Richard Cochran

The driver doesn't support timestamping of all received packets and
should return error when trying to enable the HWTSTAMP_FILTER_ALL
filter.

Cc: WingMan Kwok <w-kwok2@ti.com>
Cc: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com>
---
 drivers/net/ethernet/ti/netcp_ethss.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethernet/ti/netcp_ethss.c
index 897176f..dd92950 100644
--- a/drivers/net/ethernet/ti/netcp_ethss.c
+++ b/drivers/net/ethernet/ti/netcp_ethss.c
@@ -2651,7 +2651,6 @@ static int gbe_hwtstamp_set(struct gbe_intf *gbe_intf, struct ifreq *ifr)
 	case HWTSTAMP_FILTER_NONE:
 		cpts_rx_enable(cpts, 0);
 		break;
-	case HWTSTAMP_FILTER_ALL:
 	case HWTSTAMP_FILTER_PTP_V1_L4_EVENT:
 	case HWTSTAMP_FILTER_PTP_V1_L4_SYNC:
 	case HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ:
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] net: netcp: fix check of requested timestamping filter
  2017-05-15 14:04 [PATCH net] net: netcp: fix check of requested timestamping filter Miroslav Lichvar
@ 2017-05-15 15:03 ` Richard Cochran
  2017-05-15 19:21 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2017-05-15 15:03 UTC (permalink / raw)
  To: Miroslav Lichvar; +Cc: netdev, WingMan Kwok

On Mon, May 15, 2017 at 04:04:36PM +0200, Miroslav Lichvar wrote:
> The driver doesn't support timestamping of all received packets and
> should return error when trying to enable the HWTSTAMP_FILTER_ALL
> filter.
> 
> Cc: WingMan Kwok <w-kwok2@ti.com>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com>

Acked-by: Richard Cochran <richardcochran@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] net: netcp: fix check of requested timestamping filter
  2017-05-15 14:04 [PATCH net] net: netcp: fix check of requested timestamping filter Miroslav Lichvar
  2017-05-15 15:03 ` Richard Cochran
@ 2017-05-15 19:21 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-05-15 19:21 UTC (permalink / raw)
  To: mlichvar; +Cc: netdev, w-kwok2, richardcochran

From: Miroslav Lichvar <mlichvar@redhat.com>
Date: Mon, 15 May 2017 16:04:36 +0200

> The driver doesn't support timestamping of all received packets and
> should return error when trying to enable the HWTSTAMP_FILTER_ALL
> filter.
> 
> Cc: WingMan Kwok <w-kwok2@ti.com>
> Cc: Richard Cochran <richardcochran@gmail.com>
> Signed-off-by: Miroslav Lichvar <mlichvar@redhat.com>

Applied, thank you.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-15 19:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-15 14:04 [PATCH net] net: netcp: fix check of requested timestamping filter Miroslav Lichvar
2017-05-15 15:03 ` Richard Cochran
2017-05-15 19:21 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).