From: Florian Westphal <fw@strlen.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Mahesh Bandewar (महेश बंडेवार)" <maheshb@google.com>,
"David Miller" <davem@davemloft.net>,
gregkh@linuxfoundation.org, mahesh@bandewar.net,
mingo@kernel.org, linux-kernel@vger.kernel.org,
linux-netdev <netdev@vger.kernel.org>,
keescook@chromium.org, "Eric Dumazet" <edumazet@google.com>
Subject: Re: [PATCH] kmod: don't load module unless req process has CAP_SYS_MODULE
Date: Mon, 15 May 2017 21:59:58 +0200 [thread overview]
Message-ID: <20170515195958.GA16290@breakpoint.cc> (raw)
In-Reply-To: <87r2zqj82a.fsf@xmission.com>
Eric W. Biederman <ebiederm@xmission.com> wrote:
> If loading the conntrack module changes the semantics of packet
> processing when nothing is configured that is a bug in the conntrack
> module.
Thats the default behaviour since forever.
modprobe nf_conntrack_ipv4 -- module_init registers netfilter hooks
and starts doing connection tracking.
You might say 'its wrong' but thats how its been for over a decade.
If you have a suggestion on how to transition to a 'sane' behaviour,
then I'm all ears.
Note however, that conntrack doesn't need any configuration currently.
Its just there once module is loaded.
We could try hooking into nftables/iptables modules that use conntrack
info to make a decision, and thats what we do now in namespaces other
than init_net.
We still do it be default in iniet_net because someone could be
doing conntrack just for purpose of ctnetlink events (conntrack -E and
friends, or flow accouting and the like).
next prev parent reply other threads:[~2017-05-15 19:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 23:22 [PATCH] kmod: don't load module unless req process has CAP_SYS_MODULE Mahesh Bandewar
2017-05-14 10:45 ` Greg Kroah-Hartman
2017-05-14 13:57 ` Eric W. Biederman
2017-05-15 6:10 ` Greg Kroah-Hartman
2017-05-15 13:52 ` David Miller
2017-05-15 17:59 ` Mahesh Bandewar (महेश बंडेवार)
2017-05-15 18:14 ` David Miller
2017-05-15 18:20 ` Eric W. Biederman
2017-05-15 19:59 ` Florian Westphal [this message]
2017-05-15 2:42 ` Mahesh Bandewar (महेश बंडेवार)
2017-05-15 6:10 ` Greg Kroah-Hartman
2017-05-15 13:12 ` Eric Dumazet
2017-05-15 17:07 ` Kees Cook
2017-05-15 13:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515195958.GA16290@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).