From: David Miller <davem@davemloft.net>
To: yhs@fb.com
Cc: daniel@iogearbox.net, netdev@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH net] selftests/bpf: fix broken build due to types.h
Date: Tue, 16 May 2017 15:18:32 -0400 (EDT) [thread overview]
Message-ID: <20170516.151832.1830591267264185393.davem@davemloft.net> (raw)
In-Reply-To: <20170516184634.2803675-1-yhs@fb.com>
Please correct the address of the netdev list (it is just plain
'netdev' not 'linux-netdev').
Secondly, __always_inline should not be defined by types.h
That has to come from linux/compiler.h which we have no reason
to define a private version of for eBPF clang compilation.
The problem is that via several layers of indirection, linux/types.h
eventually includes linux/compiler.h and that is probably the more
appropriate thing for you to do.
next parent reply other threads:[~2017-05-16 19:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170516184634.2803675-1-yhs@fb.com>
2017-05-16 19:18 ` David Miller [this message]
2017-05-16 23:16 ` [PATCH net] selftests/bpf: fix broken build due to types.h Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516.151832.1830591267264185393.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox