From: David Miller <davem@davemloft.net>
To: girish.moodalbail@oracle.com
Cc: netdev@vger.kernel.org, pshelar@ovn.org, joe@ovn.org, jbenc@redhat.com
Subject: Re: [PATCH net-next] geneve: add rtnl changelink support
Date: Tue, 16 May 2017 15:31:15 -0400 (EDT) [thread overview]
Message-ID: <20170516.153115.2084299272043901950.davem@davemloft.net> (raw)
In-Reply-To: <1494870424-22699-1-git-send-email-girish.moodalbail@oracle.com>
From: Girish Moodalbail <girish.moodalbail@oracle.com>
Date: Mon, 15 May 2017 10:47:04 -0700
> if (data[IFLA_GENEVE_REMOTE]) {
> - info.key.u.ipv4.dst =
> + info->key.u.ipv4.dst =
> nla_get_in_addr(data[IFLA_GENEVE_REMOTE]);
>
> - if (IN_MULTICAST(ntohl(info.key.u.ipv4.dst))) {
> + if (IN_MULTICAST(ntohl(info->key.u.ipv4.dst))) {
> netdev_dbg(dev, "multicast remote is unsupported\n");
> return -EINVAL;
> }
> + if (changelink &&
> + ip_tunnel_info_af(&geneve->info) == AF_INET6) {
> + info->mode &= ~IP_TUNNEL_INFO_IPV6;
> + info->key.tun_flags &= ~TUNNEL_CSUM;
> + *use_udp6_rx_checksums = false;
> + }
> }
I don't understand this "changelink" guarded code, why do you need to
clear all of this state out if the existing tunnel type if AF_INET6
and only when doing a changelink?
In any event, I think you need to add a comment explaining it.
next prev parent reply other threads:[~2017-05-16 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 17:47 [PATCH net-next] geneve: add rtnl changelink support Girish Moodalbail
2017-05-16 19:31 ` David Miller [this message]
2017-05-16 20:09 ` Girish Moodalbail
2017-05-16 20:00 ` Pravin Shelar
2017-05-18 15:15 ` Girish Moodalbail
-- strict thread matches above, loose matches on Subject: below --
2017-05-08 20:08 Girish Moodalbail
2017-05-08 20:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516.153115.2084299272043901950.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=girish.moodalbail@oracle.com \
--cc=jbenc@redhat.com \
--cc=joe@ovn.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).