netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsahern@gmail.com>
Cc: Phil Sutter <phil@nwl.cc>, David Miller <davem@davemloft.net>,
	daniel@iogearbox.net, netdev@vger.kernel.org
Subject: Re: [RFC] iproute: Add support for extended ack to rtnl_talk
Date: Tue, 16 May 2017 09:36:25 -0700	[thread overview]
Message-ID: <20170516093625.178caf3f@xeon-e3> (raw)
In-Reply-To: <f847c8d4-a6c0-66ab-0ac0-d83d6ea96a00@gmail.com>

On Sat, 13 May 2017 19:29:57 -0600
David Ahern <dsahern@gmail.com> wrote:

> On 5/4/17 2:43 PM, Phil Sutter wrote:
> > So in summary, given that very little change happens to iproute2's
> > internal libnetlink, I don't see much urge to make it use libmnl as
> > backend. In my opinion it just adds another potential source of errors.
> > 
> > Eventually this should be a maintainer level decision, though. :)  
> 
> What is the decision on this?

I am waiting for a longer before committing anything. This was to allow
for a wider range of distribution maintainer feedback.

The most likely outcome is that for 4.12 is to use libmnl for extended ack.
And continue to support building without mnl with loss of functionality.

As far as conversion of all of iproute2 to libmnl. I have better things
to do... But for new functionality like extended ack, devlink, tipc, using
libmnl is easy, safe and it works well. I will continue to not accept
new  code that depends on the other library (libnl). That has come up
a couple of times.

  reply	other threads:[~2017-05-16 16:36 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 23:56 [RFC] iproute: Add support for extended ack to rtnl_talk Stephen Hemminger
2017-05-04  9:36 ` Daniel Borkmann
2017-05-04 14:27   ` David Ahern
2017-05-04 14:41     ` David Miller
2017-05-04 15:50       ` Jamal Hadi Salim
2017-05-04 16:43       ` Stephen Hemminger
2017-05-04 20:43         ` Phil Sutter
2017-05-14  1:29           ` David Ahern
2017-05-16 16:36             ` Stephen Hemminger [this message]
2017-05-18 10:02               ` Daniel Borkmann
2017-05-18 14:55                 ` Stephen Hemminger
2017-05-19  4:24                 ` David Ahern
2017-08-03 20:26                   ` David Ahern
2017-08-04 11:31                     ` Simon Horman
2017-08-04 16:47                       ` Stephen Hemminger
2017-08-07 16:48                         ` David Ahern
2017-08-07 18:06                           ` Stephen Hemminger
2017-08-07 18:09                             ` David Ahern
2017-08-07 18:45                               ` David Miller
2017-08-07 19:12                                 ` Stephen Hemminger
2017-08-07 20:26                                   ` David Miller
2017-08-07 21:21                                     ` Stephen Hemminger
2017-05-04 14:37   ` Leon Romanovsky
2017-05-04 16:45     ` Stephen Hemminger
2017-05-04 17:55       ` Leon Romanovsky
2017-05-06 10:36         ` Jiri Pirko
2017-05-04 16:42   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170516093625.178caf3f@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).