From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: David Miller <davem@davemloft.net>,
arnd@arndb.de, helmut.schaa@googlemail.com, kvalo@codeaurora.org,
daniel@makrotopia.org, dev@kresin.me, pozega.tomislav@gmail.com,
vasilugin@yandex.ru, roman@advem.lv,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rt2x00: improve calling conventions for register accessors
Date: Tue, 16 May 2017 14:43:41 +0200 [thread overview]
Message-ID: <20170516124255.GA5440@redhat.com> (raw)
In-Reply-To: <1494935936.15923.0.camel@sipsolutions.net>
On Tue, May 16, 2017 at 01:58:56PM +0200, Johannes Berg wrote:
> On Tue, 2017-05-16 at 13:55 +0200, Stanislaw Gruszka wrote:
> >
> > In rt2x00 driver we use poor convention in other kind of registers
> > accessors like bbp, mac, eeprom. I dislike to changing only rfcsr
> > accessors and leaving others in the old way. And changing all
> > accessors would be massive and error prone change, which I'm not
> > prefer either.
>
> That's a stupid argument, but for the sake of it - the conversion can
> easily be done with coccinelle/spatch without being "error prone".
Sure, but still I think it would be preferable to fix newly added
rt2800_bw_filter_calibration() function, instead of ancient rfcsr
accessors.
Stanislaw
next prev parent reply other threads:[~2017-05-16 12:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 13:46 [PATCH] rt2x00: improve calling conventions for register accessors Arnd Bergmann
2017-05-15 14:28 ` Stanislaw Gruszka
2017-05-15 14:36 ` Arnd Bergmann
2017-05-15 14:40 ` David Miller
[not found] ` <20170515.104052.1376354562934671974.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2017-05-15 19:02 ` Daniel Golle
2017-05-15 14:39 ` David Miller
2017-05-16 11:55 ` Stanislaw Gruszka
2017-05-16 11:58 ` Johannes Berg
2017-05-16 12:43 ` Stanislaw Gruszka [this message]
2017-05-16 15:37 ` David Miller
2017-05-16 13:44 ` Jes Sorensen
[not found] ` <0ce21c48-1d2c-3035-3c6e-52c7debf86d5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-16 14:19 ` Arnd Bergmann
[not found] ` <CAK8P3a18opkvCyoNmYhR6M7XXEq8f__hMZH1A6w8UFP7qbmQWw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-16 14:31 ` Jes Sorensen
[not found] ` <CAKR_QVKYpcficnx5G5NdLKh7xa9S18udYQNXDQ=LmfG=Qeapbg@mail.gmail.com>
2017-05-17 14:48 ` Arnd Bergmann
2017-05-16 14:23 ` Stanislaw Gruszka
[not found] ` <20170516142342.GA6086-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-05-16 15:11 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516124255.GA5440@redhat.com \
--to=sgruszka@redhat.com \
--cc=arnd@arndb.de \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dev@kresin.me \
--cc=helmut.schaa@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pozega.tomislav@gmail.com \
--cc=roman@advem.lv \
--cc=vasilugin@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).