From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Pirko <jiri@resnulli.us>
Subject: Re: [patch net-next v3 01/10] net: sched: move tc_classify function
 to cls_api.c
Date: Tue, 16 May 2017 23:05:14 +0200
Message-ID: <20170516210514.GT1939@nanopsycho.orion>
References: <20170516172802.1317-1-jiri@resnulli.us>
 <20170516172802.1317-2-jiri@resnulli.us>
 <CAM_iQpVqRTcK0H3wSiUEOXSk+pWtriSLFy7jtN6d77wrTjqe3Q@mail.gmail.com>
 <20170516210038.GR1939@nanopsycho.orion>
 <CAM_iQpWgtqBYEPTcdKqx=52kpmLTUug173Zdq+7gS-pniswy_A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        David Miller <davem@davemloft.net>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        David Ahern <dsa@cumulusnetworks.com>,
        Eric Dumazet <edumazet@google.com>,
        Stephen Hemminger <stephen@networkplumber.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Alexander Duyck <alexander.h.duyck@intel.com>,
        Simon Horman <simon.horman@netronome.com>, mlxsw@mellanox.com
To: Cong Wang <xiyou.wangcong@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm0-f65.google.com ([74.125.82.65]:33880 "EHLO
        mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751752AbdEPVFR (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 16 May 2017 17:05:17 -0400
Received: by mail-wm0-f65.google.com with SMTP id d127so40698556wmf.1
        for <netdev@vger.kernel.org>; Tue, 16 May 2017 14:05:16 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAM_iQpWgtqBYEPTcdKqx=52kpmLTUug173Zdq+7gS-pniswy_A@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Tue, May 16, 2017 at 11:03:14PM CEST, xiyou.wangcong@gmail.com wrote:
>On Tue, May 16, 2017 at 2:00 PM, Jiri Pirko <jiri@resnulli.us> wrote:
>> Tue, May 16, 2017 at 10:25:35PM CEST, xiyou.wangcong@gmail.com wrote:
>>>On Tue, May 16, 2017 at 10:27 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>>>> From: Jiri Pirko <jiri@mellanox.com>
>>>>
>>>> Move tc_classify function to cls_api.c where it belongs, rename it to
>>>> fit the namespace.
>>>>
>>>
>>>It is not a pure move, you silently remove the CONFIG_NET_CLS_ACT
>>>macros in tc_classify(). Probably not buggy, just redundancy when
>>>actions are not compiled.
>>
>> Plese see include/net/pkt_cls.h in this patch.
>>
>> If CONFIG_NET_CLS_ACT is not defined, there is a stub there.
>
>I am sure it is not NET_CLS_ACT:

Oh, will fix this. Thanks.

>
>
>#ifdef CONFIG_NET_CLS
> void tcf_destroy_chain(struct tcf_proto __rcu **fl);
>+int tcf_classify(struct sk_buff *skb, const struct tcf_proto *tp,
>+                struct tcf_result *res, bool compat_mode);
>+
> #else
> static inline void tcf_destroy_chain(struct tcf_proto __rcu **fl)
> {
> }
>+
>+static inline int tcf_classify(struct sk_buff *skb, const struct tcf_proto *tp,
>+                              struct tcf_result *res, bool compat_mode)
>+{
>+       return TC_ACT_UNSPEC;
>+}
> #endif