From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: paul.gortmaker@windriver.com, rdunlap@infradead.org,
sfr@canb.auug.org.au, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: fix compile error in skb_orphan_partial()
Date: Wed, 17 May 2017 15:11:20 -0400 (EDT) [thread overview]
Message-ID: <20170517.151120.2266257434113805990.davem@davemloft.net> (raw)
In-Reply-To: <1494966473.6465.13.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 16 May 2017 13:27:53 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> If CONFIG_INET is not set, net/core/sock.c can not compile :
>
> net/core/sock.c: In function ‘skb_orphan_partial’:
> net/core/sock.c:1810:2: error: implicit declaration of function
> ‘skb_is_tcp_pure_ack’ [-Werror=implicit-function-declaration]
> if (skb_is_tcp_pure_ack(skb))
> ^
>
> Fix this by always including <net/tcp.h>
>
> Fixes: f6ba8d33cfbb ("netem: fix skb_orphan_partial()")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Applied and queued up for -stable, thanks Eric.
prev parent reply other threads:[~2017-05-17 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170516112125.517607f8@canb.auug.org.au>
2017-05-16 16:28 ` linux-next: Tree for May 16 (net/core) Randy Dunlap
2017-05-16 19:44 ` Paul Gortmaker
2017-05-16 20:12 ` Eric Dumazet
2017-05-16 20:27 ` [PATCH net] net: fix compile error in skb_orphan_partial() Eric Dumazet
2017-05-17 19:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170517.151120.2266257434113805990.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox