From: Richard Cochran <richardcochran@gmail.com>
To: Soheil Hassas Yeganeh <soheil@google.com>
Cc: Miroslav Lichvar <mlichvar@redhat.com>,
netdev <netdev@vger.kernel.org>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH v3 net-next 4/7] net: add new control message for incoming HW-timestamped packets
Date: Wed, 17 May 2017 19:21:05 +0200 [thread overview]
Message-ID: <20170517172105.GB9641@localhost.localdomain> (raw)
In-Reply-To: <CACSApvY=4DrURgQrx7AwFARO2Hbo63xXbq1ayUz_Rq9HuS5qmA@mail.gmail.com>
On Wed, May 17, 2017 at 10:11:50AM -0400, Soheil Hassas Yeganeh wrote:
> On Tue, May 16, 2017 at 8:44 AM, Miroslav Lichvar <mlichvar@redhat.com> wrote:
> > +/* SCM_TIMESTAMPING_PKTINFO control message */
> > +struct scm_ts_pktinfo {
> > + __u32 if_index;
> > + __u32 pkt_length;
> > +};
> > +
>
> Given that this structure can change in the future, it might be worth
> considering using TLVs (e.g., netlink attributes), similar to what
> tcp_get_timestamping_opt_stats() does. This would simplify
> adding/removing fields to/from the control message.
[ BTW, please trim your replies. ]
Personally, I dislike TLVs. Alternatively, you could add some
reserved fields for future use.
Thanks,
Richard
next prev parent reply other threads:[~2017-05-17 17:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 12:44 [PATCH v3 net-next 0/7] Extend socket timestamping API Miroslav Lichvar
2017-05-16 12:44 ` [PATCH v3 net-next 1/7] net: define receive timestamp filter for NTP Miroslav Lichvar
2017-05-16 12:44 ` [PATCH v3 net-next 2/7] net: ethernet: update drivers to handle HWTSTAMP_FILTER_NTP_ALL Miroslav Lichvar
2017-05-16 12:44 ` [PATCH v3 net-next 3/7] net: add function to retrieve original skb device using NAPI ID Miroslav Lichvar
2017-05-16 22:29 ` Willem de Bruijn
2017-05-16 12:44 ` [PATCH v3 net-next 4/7] net: add new control message for incoming HW-timestamped packets Miroslav Lichvar
2017-05-16 22:29 ` Willem de Bruijn
2017-05-17 14:11 ` Soheil Hassas Yeganeh
2017-05-17 17:21 ` Richard Cochran [this message]
2017-05-16 12:44 ` [PATCH v3 net-next 5/7] net: don't make false software transmit timestamps Miroslav Lichvar
2017-05-16 22:34 ` Willem de Bruijn
2017-05-17 10:27 ` Miroslav Lichvar
2017-05-17 13:52 ` Willem de Bruijn
2017-05-16 12:44 ` [PATCH v3 net-next 6/7] net: allow simultaneous SW and HW transmit timestamping Miroslav Lichvar
2017-05-16 22:31 ` Willem de Bruijn
2017-05-16 12:44 ` [PATCH v3 net-next 7/7] net: ethernet: update drivers to make both SW and HW TX timestamps Miroslav Lichvar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170517172105.GB9641@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=soheil@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).