* [PATCH] udp: make function udp_skb_dtor_locked static
@ 2017-05-17 8:50 Colin King
2017-05-17 9:19 ` Paolo Abeni
2017-05-18 14:13 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-05-17 8:50 UTC (permalink / raw)
To: Paolo Abeni, David S . Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Function udp_skb_dtor_locked does not need to be in global scope
so make it static to fix sparse warning:
net/ipv4/udp.c: warning: symbol 'udp_skb_dtor_locked' was not
declared. Should it be static?
Fixes: 6dfb4367cd911d ("udp: keep the sk_receive_queue held when splicing")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/ipv4/udp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index 7bd56c9889b3..922a62d45714 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1218,7 +1218,7 @@ void udp_skb_destructor(struct sock *sk, struct sk_buff *skb)
EXPORT_SYMBOL(udp_skb_destructor);
/* as above, but the caller held the rx queue lock, too */
-void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb)
+static void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb)
{
udp_rmem_release(sk, skb->dev_scratch, 1, true);
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] udp: make function udp_skb_dtor_locked static
2017-05-17 8:50 [PATCH] udp: make function udp_skb_dtor_locked static Colin King
@ 2017-05-17 9:19 ` Paolo Abeni
2017-05-18 14:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Abeni @ 2017-05-17 9:19 UTC (permalink / raw)
To: Colin King, David S . Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev
Cc: kernel-janitors, linux-kernel
On Wed, 2017-05-17 at 09:50 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Function udp_skb_dtor_locked does not need to be in global scope
> so make it static to fix sparse warning:
>
> net/ipv4/udp.c: warning: symbol 'udp_skb_dtor_locked' was not
> declared. Should it be static?
>
> Fixes: 6dfb4367cd911d ("udp: keep the sk_receive_queue held when splicing")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> net/ipv4/udp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
> index 7bd56c9889b3..922a62d45714 100644
> --- a/net/ipv4/udp.c
> +++ b/net/ipv4/udp.c
> @@ -1218,7 +1218,7 @@ void udp_skb_destructor(struct sock *sk, struct sk_buff *skb)
> EXPORT_SYMBOL(udp_skb_destructor);
>
> /* as above, but the caller held the rx queue lock, too */
> -void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb)
> +static void udp_skb_dtor_locked(struct sock *sk, struct sk_buff *skb)
> {
> udp_rmem_release(sk, skb->dev_scratch, 1, true);
> }
Acked-by: Paolo Abeni <pabeni@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] udp: make function udp_skb_dtor_locked static
2017-05-17 8:50 [PATCH] udp: make function udp_skb_dtor_locked static Colin King
2017-05-17 9:19 ` Paolo Abeni
@ 2017-05-18 14:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-05-18 14:13 UTC (permalink / raw)
To: colin.king
Cc: pabeni, kuznet, jmorris, yoshfuji, kaber, netdev, kernel-janitors,
linux-kernel
From: Colin King <colin.king@canonical.com>
Date: Wed, 17 May 2017 09:50:36 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Function udp_skb_dtor_locked does not need to be in global scope
> so make it static to fix sparse warning:
>
> net/ipv4/udp.c: warning: symbol 'udp_skb_dtor_locked' was not
> declared. Should it be static?
>
> Fixes: 6dfb4367cd911d ("udp: keep the sk_receive_queue held when splicing")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
Please explcitily say "[PATCH net-next]" in your Subject line next time
so that it is clear what tree your patch is targetting.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-18 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-17 8:50 [PATCH] udp: make function udp_skb_dtor_locked static Colin King
2017-05-17 9:19 ` Paolo Abeni
2017-05-18 14:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).