From: David Miller <davem@davemloft.net>
To: adobriyan@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: make struct net_device::tx_queue_len unsigned int
Date: Thu, 18 May 2017 10:20:01 -0400 (EDT) [thread overview]
Message-ID: <20170518.102001.715764939763640042.davem@davemloft.net> (raw)
In-Reply-To: <20170517103044.GA28488@avx2>
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Wed, 17 May 2017 13:30:44 +0300
> 4 billion packet queue is something unthinkable so use 32-bit value
> for now.
>
> Space savings on x86_64:
>
> add/remove: 0/0 grow/shrink: 3/70 up/down: 16/-131 (-115)
> function old new delta
> change_tx_queue_len 94 108 +14
> qdisc_create 1176 1177 +1
> alloc_netdev_mqs 1124 1125 +1
> xenvif_alloc 533 532 -1
> x25_asy_setup 167 166 -1
> ...
> tun_queue_resize 945 940 -5
> pfifo_fast_enqueue 167 162 -5
> qfq_init_qdisc 168 158 -10
> tap_queue_resize 810 799 -11
> transmit 719 698 -21
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Applied.
prev parent reply other threads:[~2017-05-18 14:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 10:30 [PATCH net-next] net: make struct net_device::tx_queue_len unsigned int Alexey Dobriyan
2017-05-18 14:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518.102001.715764939763640042.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).