* [PATCH net-next] xen/9pfs: p9_trans_xen_init and p9_trans_xen_exit can be static
@ 2017-05-18 15:22 Wei Yongjun
2017-05-18 18:40 ` Stefano Stabellini
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-05-18 15:22 UTC (permalink / raw)
To: Eric Van Hensbergen, Ron Minnich, Latchesar Ionkov,
Stefano Stabellini, Juergen Gross
Cc: Wei Yongjun, v9fs-developer, netdev
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warnings:
net/9p/trans_xen.c:528:5: warning:
symbol 'p9_trans_xen_init' was not declared. Should it be static?
net/9p/trans_xen.c:540:6: warning:
symbol 'p9_trans_xen_exit' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
net/9p/trans_xen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
index 71e8564..3deb17f 100644
--- a/net/9p/trans_xen.c
+++ b/net/9p/trans_xen.c
@@ -525,7 +525,7 @@ static struct xenbus_driver xen_9pfs_front_driver = {
.otherend_changed = xen_9pfs_front_changed,
};
-int p9_trans_xen_init(void)
+static int p9_trans_xen_init(void)
{
if (!xen_domain())
return -ENODEV;
@@ -537,7 +537,7 @@ int p9_trans_xen_init(void)
}
module_init(p9_trans_xen_init);
-void p9_trans_xen_exit(void)
+static void p9_trans_xen_exit(void)
{
v9fs_unregister_trans(&p9_xen_trans);
return xenbus_unregister_driver(&xen_9pfs_front_driver);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] xen/9pfs: p9_trans_xen_init and p9_trans_xen_exit can be static
2017-05-18 15:22 [PATCH net-next] xen/9pfs: p9_trans_xen_init and p9_trans_xen_exit can be static Wei Yongjun
@ 2017-05-18 18:40 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2017-05-18 18:40 UTC (permalink / raw)
To: Wei Yongjun
Cc: Eric Van Hensbergen, Ron Minnich, Latchesar Ionkov,
Stefano Stabellini, Juergen Gross, Wei Yongjun, v9fs-developer,
netdev, boris.ostrovsky, jgross
On Thu, 18 May 2017, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warnings:
>
> net/9p/trans_xen.c:528:5: warning:
> symbol 'p9_trans_xen_init' was not declared. Should it be static?
> net/9p/trans_xen.c:540:6: warning:
> symbol 'p9_trans_xen_exit' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
If that's OK for everybody we'll queue this fix and
20170516142247.12301-1-weiyj.lk@gmail.com to the xentip tree.
> ---
> net/9p/trans_xen.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/9p/trans_xen.c b/net/9p/trans_xen.c
> index 71e8564..3deb17f 100644
> --- a/net/9p/trans_xen.c
> +++ b/net/9p/trans_xen.c
> @@ -525,7 +525,7 @@ static struct xenbus_driver xen_9pfs_front_driver = {
> .otherend_changed = xen_9pfs_front_changed,
> };
>
> -int p9_trans_xen_init(void)
> +static int p9_trans_xen_init(void)
> {
> if (!xen_domain())
> return -ENODEV;
> @@ -537,7 +537,7 @@ int p9_trans_xen_init(void)
> }
> module_init(p9_trans_xen_init);
>
> -void p9_trans_xen_exit(void)
> +static void p9_trans_xen_exit(void)
> {
> v9fs_unregister_trans(&p9_xen_trans);
> return xenbus_unregister_driver(&xen_9pfs_front_driver);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-18 18:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-18 15:22 [PATCH net-next] xen/9pfs: p9_trans_xen_init and p9_trans_xen_exit can be static Wei Yongjun
2017-05-18 18:40 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).