From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [PATCH net-next] net/mlx5e: Fix possible memory leak Date: Thu, 18 May 2017 18:58:10 +0300 Message-ID: <20170518155807.GC10691@yuval-lap> References: <20170518153441.24398-1-weiyj.lk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Saeed Mahameed , Matan Barak , Leon Romanovsky , Hadar Hen Zion , Wei Yongjun , netdev@vger.kernel.org, linux-rdma@vger.kernel.org To: Wei Yongjun Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:17029 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752823AbdERP6m (ORCPT ); Thu, 18 May 2017 11:58:42 -0400 Content-Disposition: inline In-Reply-To: <20170518153441.24398-1-weiyj.lk@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, May 18, 2017 at 03:34:41PM +0000, Wei Yongjun wrote: > From: Wei Yongjun > > 'encap_header' is malloced and should be freed before leaving from > the error handling cases, otherwise it will cause memory leak. > > Fixes: 232c001398ae ("net/mlx5e: Add support to neighbour update flow") > Signed-off-by: Wei Yongjun > --- > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > index 11c27e4..a72ecbc 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > @@ -1404,8 +1404,8 @@ static int mlx5e_create_encap_header_ipv4(struct mlx5e_priv *priv, > > if (!(nud_state & NUD_VALID)) { > neigh_event_send(n, NULL); > - neigh_release(n); > - return -EAGAIN; > + err = -EAGAIN; > + goto out; > } > > err = mlx5_encap_alloc(priv->mdev, e->tunnel_type, > @@ -1510,8 +1510,8 @@ static int mlx5e_create_encap_header_ipv6(struct mlx5e_priv *priv, > > if (!(nud_state & NUD_VALID)) { > neigh_event_send(n, NULL); > - neigh_release(n); > - return -EAGAIN; > + err = -EAGAIN; > + goto out; > } Reviewed-by: Yuval Shaia > > err = mlx5_encap_alloc(priv->mdev, e->tunnel_type, > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html