From: Matthias Kaehlcke <mka@chromium.org>
To: David Miller <davem@davemloft.net>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net1080: Mark nc_dump_ttl() as __maybe_unused
Date: Thu, 18 May 2017 09:44:29 -0700 [thread overview]
Message-ID: <20170518164429.GH141096@google.com> (raw)
In-Reply-To: <20170518.104808.963734375405821959.davem@davemloft.net>
Hi David,
El Thu, May 18, 2017 at 10:48:08AM -0400 David Miller ha dit:
> From: Matthias Kaehlcke <mka@chromium.org>
> Date: Wed, 17 May 2017 15:17:08 -0700
>
> > The function is not used, but it looks useful for debugging. Adding the
> > attribute fixes the following clang warning:
> >
> > drivers/net/usb/net1080.c:271:20: error: unused function
> > 'nc_dump_ttl' [-Werror,-Wunused-function]
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
>
> For this and the r8152 patch, I definitely prefer that the function is
> removed.
>
> If someone needs them, they can pull it out of the GIT history.
Thanks for you comments, I'll send out updated patches soon.
prev parent reply other threads:[~2017-05-18 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 22:17 [PATCH] net1080: Mark nc_dump_ttl() as __maybe_unused Matthias Kaehlcke
2017-05-18 14:48 ` David Miller
2017-05-18 16:44 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518164429.GH141096@google.com \
--to=mka@chromium.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).