From: David Miller <davem@davemloft.net>
To: stephen@networkplumber.org
Cc: netdev@vger.kernel.org, sthemmin@microsoft.com,
steffen.klassert@secunet.com
Subject: Re: [PATCH net-next 9/9] ipv6: remove unused variables in esp6
Date: Sun, 21 May 2017 13:44:36 -0400 (EDT) [thread overview]
Message-ID: <20170521.134436.268347108365784579.davem@davemloft.net> (raw)
In-Reply-To: <20170519165556.483-10-sthemmin@microsoft.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Fri, 19 May 2017 09:55:56 -0700
> Resolves warnings:
> net/ipv6/esp6.c: In function ‘esp_ssg_unref’:
> net/ipv6/esp6.c:121:10: warning: variable ‘seqhi’ set but not used [-Wunused-but-set-variable]
> net/ipv6/esp6.c: In function ‘esp6_output_head’:
> net/ipv6/esp6.c:227:21: warning: variable ‘esph’ set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Stephen please always CC: the IPSEC maintainer for IPSEC implementation
fixes.
Steffen, please consider taking this into your tree.
> ---
> net/ipv6/esp6.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c
> index 1fe99ba8066c..53b6b870b935 100644
> --- a/net/ipv6/esp6.c
> +++ b/net/ipv6/esp6.c
> @@ -118,7 +118,6 @@ static inline struct scatterlist *esp_req_sg(struct crypto_aead *aead,
>
> static void esp_ssg_unref(struct xfrm_state *x, void *tmp)
> {
> - __be32 *seqhi;
> struct crypto_aead *aead = x->data;
> int seqhilen = 0;
> u8 *iv;
> @@ -128,7 +127,6 @@ static void esp_ssg_unref(struct xfrm_state *x, void *tmp)
> if (x->props.flags & XFRM_STATE_ESN)
> seqhilen += sizeof(__be32);
>
> - seqhi = esp_tmp_seqhi(tmp);
> iv = esp_tmp_iv(aead, tmp, seqhilen);
> req = esp_tmp_req(aead, iv);
>
> @@ -224,12 +222,9 @@ int esp6_output_head(struct xfrm_state *x, struct sk_buff *skb, struct esp_info
> u8 *vaddr;
> int nfrags;
> struct page *page;
> - struct ip_esp_hdr *esph;
> struct sk_buff *trailer;
> int tailen = esp->tailen;
>
> - esph = ip_esp_hdr(skb);
> -
> if (!skb_cloned(skb)) {
> if (tailen <= skb_availroom(skb)) {
> nfrags = 1;
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-05-21 17:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 16:55 [PATCH net-next 0/9] warning cleanups Stephen Hemminger
2017-05-19 16:55 ` [PATCH net-next 1/9] dcb: enforce minimum length on IEEE_APPS attribute Stephen Hemminger
2017-05-21 17:42 ` David Miller
2017-05-19 16:55 ` [PATCH net-next 2/9] ila: propagate error code in ila_output Stephen Hemminger
2017-05-21 17:43 ` David Miller
2017-05-19 16:55 ` [PATCH net-next 3/9] udp: make local function static Stephen Hemminger
2017-05-21 17:43 ` David Miller
2017-05-19 16:55 ` [PATCH net-next 4/9] inet: fix warning about missing prototype Stephen Hemminger
2017-05-21 17:43 ` David Miller
2017-05-19 16:55 ` [PATCH net-next 5/9] tcpnv: do not export local function Stephen Hemminger
2017-05-21 17:43 ` David Miller
2017-05-19 16:55 ` [PATCH net-next 6/9] xfrm: make xfrm_dev_register static Stephen Hemminger
2017-05-20 6:48 ` Steffen Klassert
2017-05-21 17:43 ` David Miller
2017-05-19 16:55 ` [PATCH net-next 7/9] fou: make local function static Stephen Hemminger
2017-05-21 17:43 ` David Miller
2017-05-19 16:55 ` [PATCH net-next 8/9] ipv6: drop unused variables in seg6_genl_dumphac Stephen Hemminger
2017-05-21 17:43 ` David Miller
2017-05-19 16:55 ` [PATCH net-next 9/9] ipv6: remove unused variables in esp6 Stephen Hemminger
2017-05-21 17:44 ` David Miller [this message]
2017-05-22 10:59 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170521.134436.268347108365784579.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).