From: David Miller <davem@davemloft.net>
To: jan.kiszka@siemens.com
Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andy.shevchenko@gmail.com
Subject: Re: [PATCH 0/3] stmmac: pci: Refactor DMI probing
Date: Mon, 22 May 2017 14:23:11 -0400 (EDT) [thread overview]
Message-ID: <20170522.142311.1866840567813370892.davem@davemloft.net> (raw)
In-Reply-To: <16d9bbf6-0579-f16c-4177-251fa3837a2a@siemens.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
Date: Mon, 22 May 2017 19:06:07 +0200
> On 2017-05-22 18:35, David Miller wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>> Date: Mon, 22 May 2017 13:12:06 +0200
>>
>>> Some cleanups of the way we probe DMI platforms in the driver. Reduces
>>> a bit of open-coding and makes the logic easier reusable for any
>>> potential DMI platform != Quark.
>>>
>>> Tested on IOT2000 and Galileo Gen2.
>>
>> This doesn't compile:
>>
>> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:285:3: error: initializer element is not computable at load time
>> (kernel_ulong_t)&stmmac_default_setup,
>> ^
>> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:285:3: note: (near initialization for ‘stmmac_id_table[0].class’)
>> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:289:3: error: initializer element is not computable at load time
>> (kernel_ulong_t)&stmmac_default_setup,
>> ^
>> drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:289:3: note: (near initialization for ‘stmmac_id_table[1].class’)
>> scripts/Makefile.build:302: recipe for target 'drivers/net/ethernet/stmicro/stmmac/stmmac_pci.o' failed
>> make[5]: *** [drivers/net/ethernet/stmicro/stmmac/stmmac_pci.o] Error 1
>>
>
> Hmm. Which arch is this?
x86_64, allmodconfig
prev parent reply other threads:[~2017-05-22 18:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 11:12 [PATCH 0/3] stmmac: pci: Refactor DMI probing Jan Kiszka
2017-05-22 11:12 ` [PATCH 1/3] stmmac: pci: Overcome stmmac_pci_info structure Jan Kiszka
2017-05-22 17:09 ` Andy Shevchenko
2017-05-23 13:48 ` kbuild test robot
2017-05-22 11:12 ` [PATCH 2/3] stmmac: pci: Make stmmac_pci_find_phy_addr truly generic Jan Kiszka
2017-05-22 11:12 ` [PATCH 3/3] stmmac: pci: Use dmi_system_id table for retrieving PHY addresses Jan Kiszka
2017-05-22 11:33 ` Joe Perches
2017-05-22 12:49 ` Jan Kiszka
2017-05-22 13:13 ` Joe Perches
2017-05-22 16:59 ` Andy Shevchenko
2017-05-22 16:35 ` [PATCH 0/3] stmmac: pci: Refactor DMI probing David Miller
2017-05-22 17:06 ` Jan Kiszka
2017-05-22 18:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522.142311.1866840567813370892.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=andy.shevchenko@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).