From: David Miller <davem@davemloft.net>
To: cera@cera.cz
Cc: netdev@vger.kernel.org, sashok@cumulusnetworks.com,
stephen@networkplumber.org, bridge@lists.linux-foundation.org,
lucien.xin@gmail.com, nikolay@cumulusnetworks.com
Subject: Re: [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping
Date: Mon, 22 May 2017 14:41:30 -0400 (EDT) [thread overview]
Message-ID: <20170522.144130.1968086500919533289.davem@davemloft.net> (raw)
In-Reply-To: <20170519173043.10201-1-cera@cera.cz>
From: Ivan Vecera <cera@cera.cz>
Date: Fri, 19 May 2017 19:30:43 +0200
> Current bridge code incorrectly handles starting/stopping of hello and
> hold timers during STP enable/disable.
>
> 1. Timers are stopped in br_stp_start() during NO_STP->USER_STP
> transition. The timers are already stopped in NO_STP state so
> this is confusing no-op.
>
> 2. During USER_STP->NO_STP transition the timers are started. This
> does not make sense and is confusion because the timer should not be
> active in NO_STP state.
>
> Cc: davem@davemloft.net
> Cc: sashok@cumulusnetworks.com
> Cc: stephen@networkplumber.org
> Cc: bridge@lists.linux-foundation.org
> Cc: lucien.xin@gmail.com
> Cc: nikolay@cumulusnetworks.com
> Signed-off-by: Ivan Vecera <cera@cera.cz>
Applied.
prev parent reply other threads:[~2017-05-22 18:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 17:30 [PATCH net-next v2] bridge: fix hello and hold timers starting/stopping Ivan Vecera
2017-05-19 17:35 ` Xin Long
2017-05-19 20:12 ` Nikolay Aleksandrov
2017-05-20 5:57 ` Hangbin Liu
2017-05-20 6:55 ` Nikolay Aleksandrov
2017-05-20 7:06 ` Ivan Vecera
2017-05-20 7:47 ` Hangbin Liu
2017-05-22 18:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522.144130.1968086500919533289.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=cera@cera.cz \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=sashok@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).