From: David Miller <davem@davemloft.net>
To: qinteng@fb.com
Cc: peterz@infradead.org, bgregg@netflix.com, daniel@iogearbox.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Kernel-team@fb.com, ast@fb.com
Subject: Re: [PATCH net-next] bpf: update perf event helper function signature and documentation
Date: Mon, 22 May 2017 23:08:49 -0400 (EDT) [thread overview]
Message-ID: <20170522.230849.1056416550811494880.davem@davemloft.net> (raw)
In-Reply-To: <E796EF36-C195-4FFA-AAA0-A1F9E7730349@fb.com>
From: Teng Qin <qinteng@fb.com>
Date: Tue, 23 May 2017 00:39:34 +0000
> diff --git a/samples/bpf/bpf_helpers.h b/samples/bpf/bpf_helpers.h
> index 9a9c95f..a94ce42 100644
> --- a/samples/bpf/bpf_helpers.h
> +++ b/samples/bpf/bpf_helpers.h
> @@ -37,9 +37,8 @@ static int (*bpf_clone_redirect)(void *ctx, int ifindex, int flags) =
> (void *) BPF_FUNC_clone_redirect;
> static int (*bpf_redirect)(int ifindex, int flags) =
> (void *) BPF_FUNC_redirect;
> -static int (*bpf_perf_event_output)(void *ctx, void *map,
> - unsigned long long flags, void *data,
> - int size) =
> +static int (*bpf_perf_event_output)(void *ctx, void *map, u64 flags,
> + void *data, int size) =
> (void *) BPF_FUNC_perf_event_output;
> static int (*bpf_get_stackid)(void *ctx, void *map, int flags) =
> (void *) BPF_FUNC_get_stackid;
I think we've been intentionally avoiding the use of "u64", "u32",
etc. in this file.
But what do I know.
next prev parent reply other threads:[~2017-05-23 3:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 0:39 [PATCH net-next] bpf: update perf event helper function signature and documentation Teng Qin
2017-05-23 3:08 ` David Miller [this message]
2017-05-23 3:17 ` Teng Qin
2017-05-25 16:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522.230849.1056416550811494880.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Kernel-team@fb.com \
--cc=ast@fb.com \
--cc=bgregg@netflix.com \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=qinteng@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox