From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Ricardo Leitner Subject: Re: [PATCH 2/5] sctp: Delete an error message for a failed memory allocation in sctp_init() Date: Mon, 22 May 2017 13:56:58 -0300 Message-ID: <20170522165658.GA4642@localhost.localdomain> References: <2845df67-d35d-536a-0a53-b2eb83fe1ba5@users.sourceforge.net> <7db0cb49-109b-88a6-532f-c591cc8ffa85@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Neil Horman , Vlad Yasevich , LKML , kernel-janitors@vger.kernel.org To: SF Markus Elfring Return-path: Content-Disposition: inline In-Reply-To: <7db0cb49-109b-88a6-532f-c591cc8ffa85@users.sourceforge.net> Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, May 22, 2017 at 06:38:21PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 22 May 2017 17:28:14 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring > --- > net/sctp/protocol.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c > index 2b1a6215bd2f..5e7c8a344770 100644 > --- a/net/sctp/protocol.c > +++ b/net/sctp/protocol.c > @@ -1447,5 +1447,4 @@ static __init int sctp_init(void) > if (!sctp_ep_hashtable) { > - pr_err("Failed endpoint_hash alloc\n"); Okay but then why not also delete the one a few lines below this one: if (!sctp_port_hashtable) { pr_err("Failed bind hash alloc\n"); status = -ENOMEM; goto err_bhash_alloc; } Seems the same pattern to me. > status = -ENOMEM; > goto err_ehash_alloc; > } > -- > 2.13.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sctp" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >