Re: [PATCH 1/2] ip: include libc headers first

Stephen Hemminger
2017-05-31T00:31:54Z

On Mon, 22 May 2017 16:27:53 +0300
Baruch Siach <baruch@tkos.co.il> wrote:

> Including libc headers first helps as a workaround to redefinition of struct
> ethhdr with a suitably patched musl libc that suppresses the kernel
> if_ether.h.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> ip/iplink_bridge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ip/iplink_bridge.c b/ip/iplink_bridge.c
> index 818b43c89b5b..cccdec1c203a 100644
> --- a/ip/iplink_bridge.c
> +++ b/ip/iplink_bridge.c
> @@ -13,9 +13,9 @@
> #include <stdlib.h>
> #include <string.h>
> #include <netinet/in.h>
> +#include <netinet/ether.h>
> #include <linux/if_link.h>
> #include <linux/if_bridge.h>
> -#include <netinet/ether.h>
> #include <net/if.h>
>
> #include "rt_names.h"

Applied.

Next time please fix the Subject line. You implied two patches by using 1/2
but only one was sent.

It is easier for me if you include iproute2 in subject since then it goes into a
separate folder.

Subject: [PATCH iproute2] ip: include libc headers first

or if intended for net-next

Subject: [PATCH iproute2 net-next] ip: add magic VRF support