netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Bogdan Purcareata <bogdan.purcareata@nxp.com>
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] net: phy: Update get_phy_c45_ids for Cortina PHYs
Date: Tue, 23 May 2017 18:03:53 +0200	[thread overview]
Message-ID: <20170523160353.GB21169@lunn.ch> (raw)
In-Reply-To: <1495554799-23060-2-git-send-email-bogdan.purcareata@nxp.com>

On Tue, May 23, 2017 at 03:53:18PM +0000, Bogdan Purcareata wrote:
> Complete the work started by the following patches
> 5f6c99e0 net: phy: fix a bug in get_phy_c45_ids
> da1da284 net/phy: tune get_phy_c45_ids to support more c45 phy
> 
> in order to properly get non-standard C45 10G PHY IDs (e.g. Cortina
> CS4340).

At a first look, this seems to be a hack to work around a broken phy.

Instead of this, can you use the ethernet-phy-id property in device
tree?

	Andrew

  reply	other threads:[~2017-05-23 16:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-23 15:53 [PATCH 0/2] net: phy: Support managed Cortina phys Bogdan Purcareata
2017-05-23 15:53 ` [PATCH 1/2] net: phy: Update get_phy_c45_ids for Cortina PHYs Bogdan Purcareata
2017-05-23 16:03   ` Andrew Lunn [this message]
2017-05-23 16:32     ` Bogdan Purcareata
2017-05-23 16:55       ` Andrew Lunn
2017-05-23 18:12         ` Florian Fainelli
2017-05-24  6:05           ` Bogdan Purcareata
2017-05-23 15:53 ` [PATCH 2/2] drivers: phy: Add Cortina CS4340 driver Bogdan Purcareata
2017-05-23 15:57   ` Andrew Lunn
2017-05-23 16:32     ` Bogdan Purcareata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170523160353.GB21169@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=bogdan.purcareata@nxp.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).