From: Taehee Yoo <ap420073@gmail.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Taehee Yoo <ap420073@gmail.com>
Subject: [PATCH] rhashtable: Fix missing elements when inserting.
Date: Wed, 24 May 2017 10:49:50 +0900 [thread overview]
Message-ID: <20170524014950.3261-1-ap420073@gmail.com> (raw)
rhltable_insert_key() inserts a node into list of element,
if node's key is duplicated, so that it becomes the chain of
element(as known as rhead). Also bucket table points that element directly.
If a inserted node's element chain is located at third,
rhltable misses first and second element chain.
This issue is causion of to failture the rhltable_remove().
After this patch, rhltable_insert_key() inserts a node into second of
element's list, so that rhlist do not misses elements.
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
include/linux/rhashtable.h | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h
index 7d56a7e..d3c24b9 100644
--- a/include/linux/rhashtable.h
+++ b/include/linux/rhashtable.h
@@ -762,11 +762,9 @@ static inline void *__rhashtable_insert_fast(
list = container_of(obj, struct rhlist_head, rhead);
plist = container_of(head, struct rhlist_head, rhead);
- RCU_INIT_POINTER(list->next, plist);
- head = rht_dereference_bucket(head->next, tbl, hash);
- RCU_INIT_POINTER(list->rhead.next, head);
- rcu_assign_pointer(*pprev, obj);
-
+ RCU_INIT_POINTER(list->next, rht_dereference_bucket(plist->next,
+ tbl, hash));
+ RCU_INIT_POINTER(plist->next, list);
goto good;
}
--
2.9.3
next reply other threads:[~2017-05-24 1:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 1:49 Taehee Yoo [this message]
2017-05-24 4:36 ` [PATCH] rhashtable: Fix missing elements when inserting Herbert Xu
2017-05-24 16:13 ` Taehee Yoo
2017-05-24 16:17 ` Taehee Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524014950.3261-1-ap420073@gmail.com \
--to=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox