From: Andrew Lunn <andrew@lunn.ch>
To: Timur Tabi <timur@codeaurora.org>
Cc: Matthias May <matthias.may@neratec.com>,
Zefir Kurtisi <zefir.kurtisi@neratec.com>,
netdev@vger.kernel.org, f.fainelli@gmail.com,
David Miller <davem@davemloft.net>,
Manoj Iyer <manoj.iyer@canonical.com>,
jhugo@codeaurora.org
Subject: Re: [PATCH 2/2] at803x: double check SGMII side autoneg
Date: Wed, 24 May 2017 15:40:21 +0200 [thread overview]
Message-ID: <20170524134021.GA26577@lunn.ch> (raw)
In-Reply-To: <a88a111d-5e3a-0999-14ef-0ada06febb3f@codeaurora.org>
> >Since aneg is mandatory for SGMII this can as well be seen as "link not up", not?
>
> The problem is that even though the link is up, the driver has
> returned "0", so the kernel thinks that autonegotiation has not
> finished.
You need to prove this, that the link is not up. Any by link, we mean
both the copper and the SGMII link.
> at803x_aneg_done() is never called again, and so I think
> the kernel is disabling the interface is some secret way.
Well, the driver has told the core that the link is not up. So the
kernel is waiting for another interrupt indicating the link has gone
up. And probably, this second interrupt never happens.
And it is not disabling the interface. Since the PHY is still down,
the core has not called netif_carrier_on().
Andrew
next prev parent reply other threads:[~2017-05-24 13:40 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 10:40 [PATCH 0/2] at803x: don't power-down SGMII link Zefir Kurtisi
2016-10-24 10:40 ` [PATCH 1/2] Revert "at803x: fix suspend/resume for SGMII link" Zefir Kurtisi
2016-10-27 20:05 ` David Miller
2016-10-24 10:40 ` [PATCH 2/2] at803x: double check SGMII side autoneg Zefir Kurtisi
2016-10-27 20:05 ` David Miller
2016-10-28 22:24 ` Timur Tabi
2016-11-01 11:13 ` Zefir Kurtisi
2017-01-17 23:32 ` Timur Tabi
2017-01-18 11:00 ` Zefir Kurtisi
2017-01-18 13:13 ` Timur Tabi
2017-01-18 13:53 ` Zefir Kurtisi
2017-01-18 15:02 ` Timur Tabi
2017-01-19 9:43 ` Zefir Kurtisi
2017-01-19 18:01 ` Florian Fainelli
2017-01-20 2:38 ` Timur Tabi
2017-01-20 15:31 ` Zefir Kurtisi
2017-05-22 20:12 ` Timur Tabi
2017-05-22 21:02 ` Andrew Lunn
2017-05-22 21:10 ` Florian Fainelli
2017-05-22 21:19 ` Timur Tabi
2017-05-22 21:50 ` Florian Fainelli
2017-05-22 21:09 ` Andrew Lunn
2017-05-22 21:29 ` Timur Tabi
2017-05-22 21:32 ` Andrew Lunn
2017-05-23 15:54 ` Timur Tabi
2017-05-23 16:07 ` Andrew Lunn
2017-05-23 16:33 ` Timur Tabi
2017-05-24 7:18 ` Matthias May
2017-05-24 13:29 ` Timur Tabi
2017-05-24 13:40 ` Andrew Lunn [this message]
2017-05-24 13:48 ` Timur Tabi
2017-05-24 14:09 ` Andrew Lunn
2017-05-24 18:58 ` Timur Tabi
2017-05-24 19:34 ` Andrew Lunn
2017-05-24 20:57 ` Timur Tabi
2017-05-24 21:15 ` Andrew Lunn
2017-05-24 21:20 ` Timur Tabi
2017-05-24 21:28 ` Florian Fainelli
2017-05-24 21:32 ` Timur Tabi
2017-05-24 21:36 ` Florian Fainelli
2017-05-24 22:03 ` Timur Tabi
2017-05-24 21:19 ` Florian Fainelli
2017-06-01 11:45 ` Zefir Kurtisi
2017-06-01 14:48 ` Timur Tabi
2016-10-25 17:31 ` [PATCH 0/2] at803x: don't power-down SGMII link Timur Tabi
2016-10-27 8:05 ` Zefir Kurtisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524134021.GA26577@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jhugo@codeaurora.org \
--cc=manoj.iyer@canonical.com \
--cc=matthias.may@neratec.com \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).