From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: p.fiterau-brostean@science.ru.nl, netdev@vger.kernel.org,
F.Vaandrager@cs.ru.nl, ncardwell@google.com, ycheng@google.com,
soheil@google.com
Subject: Re: [PATCH net-next] tcp: better validation of received ack sequences
Date: Thu, 25 May 2017 12:48:17 -0400 (EDT) [thread overview]
Message-ID: <20170525.124817.1960721450872387047.davem@davemloft.net> (raw)
In-Reply-To: <1495578286.6465.90.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 23 May 2017 15:24:46 -0700
> Add a FLAG_NO_CHALLENGE_ACK so that tcp_rcv_state_process()
> can choose to send a challenge ACK and discard the packet instead
> of wrongly change socket state.
Applied, but the tests end up being double-negatives so it might
have been easier to understand if the flag was a positive rather
than a negative value.
next prev parent reply other threads:[~2017-05-25 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 20:29 Non-standard TCP stack processing of packets with unacceptable ACK numbers Paul Fiterau Brostean
2017-04-10 15:34 ` Eric Dumazet
2017-05-23 22:24 ` [PATCH net-next] tcp: better validation of received ack sequences Eric Dumazet
2017-05-25 16:48 ` David Miller [this message]
2017-05-25 16:50 ` Eric Dumazet
2017-05-25 17:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170525.124817.1960721450872387047.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=F.Vaandrager@cs.ru.nl \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=p.fiterau-brostean@science.ru.nl \
--cc=soheil@google.com \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox